Merge pull request MyArtverse-Project#19 from Beta-Folf/fix-react-keys

refactor: fix react keys where able to
ulf-frostypaw · Jun 24, 2022 · e8d3470 · e8d3470
2 parents 30900c7 + fbae813
commit e8d3470
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 12 deletions.
diff --git a/src/components/CardCarousel.tsx b/src/components/CardCarousel.tsx
@@ -60,12 +60,8 @@ const CardCarousel = ({ title, type, items = [] }: ICarouselProps) => {
         <div id={styles["card-wrapper"]} ref={carouselRef}>
           <div id={styles["cards"]}>
             {items.length >= 5
-              ? items.map((item, index) => (
-                  <GalleryItem key={index} {...item} />
-                ))
-              : items.map((item, index) => (
-                  <GalleryItem key={index} {...item} />
-                ))}
+              ? items.map((item) => <GalleryItem key={item.link} {...item} />)
+              : items.map((item) => <GalleryItem key={item.link} {...item} />)}
             {Array(5 - items.length)
               .fill(0)
               .map((_, index) => (

diff --git a/src/components/CarouselMenu.tsx b/src/components/CarouselMenu.tsx
@@ -60,11 +60,9 @@ const CardCarousel = ({ title, type, items = [] }: ICarouselProps) => {
         <div id={styles["card-wrapper"]} ref={carouselRef}>
           <div id={styles["cards"]}>
             {items.length >= 5
-              ? items.map((item, index) => (
-                  <GalleryItem key={index} {...item} />
-                ))
+              ? items.map((item) => <GalleryItem key={item.link} {...item} />)
               : items.map((item, index) => (
-                  <GalleryItem key={index} {...item} />
+                  <GalleryItem key={item.link} {...item} />
                 ))}
             {Array(5 - items.length)
               .fill(0)

diff --git a/src/components/Layout.tsx b/src/components/Layout.tsx
@@ -1,6 +1,6 @@
 import Head from "next/head"
 import Header from "./Header"
-import Footer from "./Footer"
+// import Footer from "./Footer"
 
 export default function Layout({ children }) {
   return (
@@ -16,7 +16,7 @@ export default function Layout({ children }) {
       <div>
         <Header />
         {children}
-        <Footer />
+        {/* <Footer /> */}
       </div>
     </>
   )