Skip to content

switch inline style to use height and width instead #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jwrubel
Copy link

@jwrubel jwrubel commented Jul 30, 2016

Hi! I stumbled across your library and am really glad I did. I noticed your inline style application applies a right and bottom property. When I pull up your sample letter it looks like this in Chrome:
letter_html 2

I think you are intending to set the bounding box for each word, in which case instead of right and bottom, the CSS properties width and height should be used, so that properties like outline and background will be able to determine the box dimensions. When I apply the changes in this pull request, the letter looks like this:

letter_html

From what I can see of the code it looks like that's more what you intended for the effect of the library. If not, feel free to close/ingore this PR.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant