Port of 'explicitly cancel frame loop on stop' from @znah (#13)

src/core/loop.js

@@ -11,12 +11,14 @@ THREE.Bootstrap.registerPlugin("loop", {
 
   install: function (three) {
     this.running = false;
+    this.lastRequestId = null;
 
     three.Loop = this.api(
       {
         start: this.start.bind(this),
         stop: this.stop.bind(this),
         running: false,
+        window: window,
       },
       three
     );
@@ -40,16 +42,13 @@ THREE.Bootstrap.registerPlugin("loop", {
     three.Loop.running = this.running = true;
 
     var trigger = three.trigger.bind(three);
-    var frames = 0;
     var loop = function () {
-      this.running && requestAnimationFrame(loop);
-      frames = (frames + 1) % Math.max(1, this.options.each);
-      if (frames == 0) {
-        this.events.map(trigger);
-      }
+      if (!this.running) return;
+      this.lastRequestId = three.Loop.window.requestAnimationFrame(loop);
+      this.events.map(trigger);
     }.bind(this);
 
-    requestAnimationFrame(loop);
+    this.lastRequestId = three.Loop.window.requestAnimationFrame(loop);
 
     three.trigger({ type: "start" });
   },
@@ -58,6 +57,9 @@ THREE.Bootstrap.registerPlugin("loop", {
     if (!this.running) return;
     three.Loop.running = this.running = false;
 
+    three.Loop.window.cancelAnimationFrame(this.lastRequestId);
+    this.lastRequestId = null;
+
     three.trigger({ type: "stop" });
   },
 });