Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(service): New subcmd to drain services and fixes #2216

Conversation

nderjung
Copy link
Member

@nderjung nderjung commented Mar 7, 2025

Prerequisite checklist

  • Read the contribution guidelines regarding submitting new changes to the project;
  • Tested your changes against relevant architectures and platforms;
  • Ran make fmt on your commit series before opening this PR;
  • Updated relevant documentation.

Description of changes

@nderjung nderjung requested a review from craciunoiuc March 7, 2025 12:29
@nderjung nderjung force-pushed the nderjung/feat/internal/cli/kraft/cloud/service/drain/init branch from 5f9b40f to dd4edb6 Compare March 7, 2025 12:32
@nderjung nderjung force-pushed the nderjung/feat/internal/cli/kraft/cloud/service/drain/init branch from dd4edb6 to c46713d Compare March 7, 2025 12:37
Copy link
Member

@craciunoiuc craciunoiuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good here. Thanks!

Reviewed-by: Cezar Craciunoiu [email protected]
Approved-by: Cezar Craciunoiu [email protected]

@craciunoiuc craciunoiuc merged commit df33925 into unikraft:staging Mar 7, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🚀 Done
Development

Successfully merging this pull request may close these issues.

2 participants