Classify a few types comforming to Initializer as a new protocol `S…

…ervice` instead, to be more intention revealing, reflecting that they are long-running

AlphaWallet/Common/Services/Application.swift

@@ -44,8 +44,7 @@ protocol ApplicationNavigatable: RestartQueueNavigatable, DonationUserActivityHa
 
 // swiftlint:disable type_body_length
 class Application: WalletDependenciesProvidable {
-    //TODO rename and replace type? Not Initializer but similar as of writing
-    private var services: [Initializer] = []
+    private var services: [Service] = []
     private let dependencies: AtomicDictionary<Wallet, WalletDependencies> = .init()
     private var cancelable = Set<AnyCancellable>()
     private let launchOptionsService: LaunchOptionsService
@@ -430,14 +429,14 @@ class Application: WalletDependenciesProvidable {
             CleanupPasscode(keystore: keystore, lock: lock),
             KeyboardInitializer(),
             DatabasePathLog(),
-            TickerIdsMatchLog()
         ]
 
         initializers.forEach { $0.perform() }
     }
 
     private func runServices() {
         services = [
+            TickerIdsMatchLog(),
             ReportUsersWalletAddresses(keystore: keystore),
             ReportUsersActiveChains(serversProvider: serversProvider),
             MigrateToSupportEip1559Transactions(

modules/AlphaWalletFoundation/AlphaWalletFoundation/Initializers/ConfigureApp.swift

@@ -6,6 +6,7 @@
 //
 
 import Foundation
+import AlphaWalletLogger
 import AlphaWalletOpenSea
 import AlphaWalletENS
 
@@ -17,24 +18,11 @@ public class ConfigureApp: Initializer {
     }
 }
 
-import AlphaWalletLogger
 public class DatabasePathLog: Initializer {
     public init() {}
     public func perform() {
         let config = RealmConfiguration.configuration(name: "")
         debugLog("Database filepath: \(config.fileURL!)")
         debugLog("Database directory: \(config.fileURL!.deletingLastPathComponent())")
     }
-}
-
-public class TickerIdsMatchLog: Initializer {
-    public init() {}
-    public func perform() {
-        if Features.default.isAvailable(.isLoggingEnabledForTickerMatches) {
-            Timer.scheduledTimer(withTimeInterval: 5, repeats: true) { _ in
-                infoLog("Ticker ID positive matching counts: \(TickerIdFilter.matchCounts)")
-            }
-        }
-    }
-}
-
+}

modules/AlphaWalletFoundation/AlphaWalletFoundation/Initializers/MigrateToSupportEip1559Transactions.swift

@@ -9,7 +9,7 @@ import Foundation
 import Combine
 import AlphaWalletLogger
 
-public final class MigrateToSupportEip1559Transactions: Initializer {
+public final class MigrateToSupportEip1559Transactions: Service {
     private let serversProvider: ServersProvidable
     private let keychain: Keystore
     private var cancelable = Set<AnyCancellable>()
@@ -35,7 +35,7 @@ public final class MigrateToSupportEip1559Transactions: Initializer {
                     let storage = TransactionDataStore(store: RealmStore.storage(for: wallet))
                     storage.deleteAll()
                 }
-                
+
                 Config.setAsMigratedToEip1559TransactionsSupport()
             }.store(in: &cancelable)
     }

modules/AlphaWalletFoundation/AlphaWalletFoundation/Initializers/ReportUsersActiveChains.swift

@@ -3,7 +3,7 @@
 import Foundation
 import Combine
 
-public final class ReportUsersActiveChains: Initializer {
+public final class ReportUsersActiveChains: Service {
     private let serversProvider: ServersProvidable
     private var cancelable = Set<AnyCancellable>()
 

modules/AlphaWalletFoundation/AlphaWalletFoundation/Initializers/ReportUsersWalletAddresses.swift

@@ -8,7 +8,7 @@
 import Foundation
 import Combine
 
-public final class ReportUsersWalletAddresses: Initializer {
+public final class ReportUsersWalletAddresses: Service {
     private let keystore: Keystore
     private var cancelable = Set<AnyCancellable>()
 

modules/AlphaWalletFoundation/AlphaWalletFoundation/Services/Service.swift

@@ -0,0 +1,7 @@
+// Copyright © 2023 Stormbird PTE. LTD.
+
+import Foundation
+
+public protocol Service {
+    func perform()
+}

modules/AlphaWalletFoundation/AlphaWalletFoundation/Services/TickerIdsMatchLog.swift

@@ -0,0 +1,15 @@
+// Copyright © 2023 Stormbird PTE. LTD.
+
+import AlphaWalletLogger
+import Foundation
+
+public class TickerIdsMatchLog: Service {
+    public init() {}
+    public func perform() {
+        if Features.default.isAvailable(.isLoggingEnabledForTickerMatches) {
+            Timer.scheduledTimer(withTimeInterval: 5, repeats: true) { _ in
+                infoLog("Ticker ID positive matching counts: \(TickerIdFilter.matchCounts)")
+            }
+        }
+    }
+}

resources/SwiftFormatFiles.xcfilelist

@@ -13,3 +13,5 @@ $(SRCROOT)/AlphaWalletTests/Tokens/TokensDataStoreTest.swift
 $(SRCROOT)/AlphaWalletTests/Tokens/Helpers/TokenAdaptorTest.swift
 $(SRCROOT)/modules/AlphaWalletENS/AlphaWalletENS/ENS.swift
 $(SRCROOT)/modules/AlphaWalletFoundation/AlphaWalletFoundation/Types/RPCServers.swift
+$(SRCROOT)/modules/AlphaWalletFoundation/AlphaWalletFoundation/Services/Service.swift
+$(SRCROOT)/modules/AlphaWalletFoundation/AlphaWalletFoundation/Services/TickerIdsMatchLog.swift