Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle np.float in logfile, getitem preserves settings #271

Merged
merged 1 commit into from
Jan 24, 2025
Merged

handle np.float in logfile, getitem preserves settings #271

merged 1 commit into from
Jan 24, 2025

Conversation

mmckerns
Copy link
Member

Summary

  • np.float may be written to logfile, so needs to have numpy imported as np
  • when getting a slice of a monitor, getitem should preserve monitor internal settings

Checklist

Documentation and Tests

  • Added relevant documentation that builds in sphinx without error.
  • Added new features that are documented with examples.
  • Artifacts produced with the main branch work as expected under this PR.

Release Management

  • Added rationale for any breakage of backwards compatibility.

@mmckerns mmckerns added this to the mystic-0.4.4 milestone Jan 24, 2025
@mmckerns mmckerns merged commit 31b28c9 into master Jan 24, 2025
2 of 4 checks passed
@mmckerns mmckerns deleted the monitortweaks branch January 24, 2025 02:25
@mmckerns mmckerns mentioned this pull request Jan 28, 2025
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
mystic-0.4.4
Development

Successfully merging this pull request may close these issues.
1 participant
@mmckerns