-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(restapi): added signature analysis workflow endpoint & tests #719
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Want to have a discussion to make sure we are capturing the types how we want in the output.
src/dioptra/client/workflows.py
Outdated
json_={"filename": filename, "fileContents": fileContents}, | ||
) | ||
|
||
def signature_analysis_file(self, filename: str) -> T: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of having separate methods, can we overload a single method and either read from file or from contents depending on which args are passed?
This was the guidance James gave me for my import workflow. See here for an example:
dioptra/src/dioptra/client/workflows.py
Line 96 in 16d3401
@overload |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are these files in examples showing as changed?
This commit adds a module for statically analyzing Python code to find plugin task function signatures. It includes a new test suite for testing the module.
This commit exposes the signature analysis module as a workflow in the Dioptra REST API. It updates the Python client to support the new workflow. It also includes a new test suite the provides test coverage for the workflow and client.
6487cd6
to
3b81da4
Compare
Closes #691