Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(restapi): added signature analysis workflow endpoint & tests #719

Merged
merged 2 commits into from
Feb 19, 2025

Conversation

jtsextonMITRE
Copy link
Collaborator

Closes #691

Copy link
Collaborator

@keithmanville keithmanville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want to have a discussion to make sure we are capturing the types how we want in the output.

json_={"filename": filename, "fileContents": fileContents},
)

def signature_analysis_file(self, filename: str) -> T:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of having separate methods, can we overload a single method and either read from file or from contents depending on which args are passed?

This was the guidance James gave me for my import workflow. See here for an example:

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are these files in examples showing as changed?

chisholm and others added 2 commits February 19, 2025 12:28
This commit adds a module for statically analyzing Python code to find plugin task function
signatures. It includes a new test suite for testing the module.
This commit exposes the signature analysis module as a workflow in the Dioptra REST API. It updates
the Python client to support the new workflow. It also includes a new test suite the provides test
coverage for the workflow and client.
@keithmanville keithmanville force-pushed the jtsexton-signature-analysis-workflow branch from 6487cd6 to 3b81da4 Compare February 19, 2025 17:41
@keithmanville keithmanville merged commit 3b81da4 into dev Feb 19, 2025
11 checks passed
@keithmanville keithmanville deleted the jtsexton-signature-analysis-workflow branch February 19, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add plugin task type inference workflow Add a plugin task type inference workflow for missing types
4 participants