Skip to content

Conversation

Pazus
Copy link
Member

@Pazus Pazus commented Mar 30, 2019

Cuurent approach to versioning with manual control of the version number being deplys leads to errors when second commit on develop branch uses the same version as non-snapshot artifact may only be uploaded once.

In this PR I suggest another approach when non-SNAPSHOT artifact is created only for tagged builds with tag like (v)#.#.# where "v" is optional.
I also slightly updated gradle and junit

@Pazus Pazus requested a review from pesse March 30, 2019 13:02
Copy link
Member

@pesse pesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change, thanks a lot!

@pesse pesse merged commit 2ea07e4 into develop Apr 1, 2019
@pesse pesse deleted the feature/deploy-on-tag branch April 1, 2019 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants