-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix and enforce MSRV by building all features during CI #6755
base: main
Are you sure you want to change the base?
Fix and enforce MSRV by building all features during CI #6755
Conversation
Specifically: $ cargo update -p selinux-sys --precise 0.6.10 Updating crates.io index Adding bindgen v0.69.4 Adding home v0.5.9 Adding itertools v0.12.1 Adding lazycell v1.3.0 Downgrading selinux-sys v0.6.12 -> v0.6.10 Adding which v4.4.2 $ cargo update -p fts-sys --precise 0.2.9 Updating crates.io index Removing bindgen v0.70.1 Downgrading fts-sys v0.2.11 -> v0.2.9 It also required itertools, once_cell, and zip.
558f74b
to
162055d
Compare
I see only these options:
All of these are terrible. @sylvestre How would you like to proceed? |
What is really the problem with raising the MSRV to 1.77.0? Debian stable uses rust 1.65.0 by default, which is older than 1.70 anyway so people stuck with Debian stable have to use rustup and can probably use 1.77.0 (which is more than 6 months old). Debian testing uses 1.80.1, so this is ok. Who are the "customers" of |
Feel free to open a PR to do so, but I don't want to make a decision on this. |
@samueltardieu @BenWiederhake |
This PR:
fts-sys
andselinux-sys
#6339) to achieve MSRV 1.70.0 againNote that the latter requires that we split the text step into two steps, because
cargo nextest --all-features
would also include features such astest_unimplemented
andexpensive_tests
, which would always break.Fixes #6728.