Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stty: fix negated operands #6798

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

andrewliebenow
Copy link
Contributor

Also: use correct file descriptor (stdin) to look up tty
Also: fix handling of end of options delimiter ("--")
Also: use StdoutLock for printing

Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/timeout/timeout is no longer failing!

Copy link

GNU testsuite comparison:

GNU test failed: tests/timeout/timeout. tests/timeout/timeout is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/tail/assert is no longer failing!
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

@andrewliebenow andrewliebenow force-pushed the stty-fix-negation-and-other-bugs branch from 71b99a3 to 204062e Compare October 20, 2024 16:59
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/timeout/timeout is no longer failing!

Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

@andrewliebenow andrewliebenow force-pushed the stty-fix-negation-and-other-bugs branch 2 times, most recently from 0feb930 to 97868ee Compare November 1, 2024 04:04
@sylvestre sylvestre force-pushed the stty-fix-negation-and-other-bugs branch from 97868ee to 1c59495 Compare November 16, 2024 19:17
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

@sylvestre sylvestre force-pushed the stty-fix-negation-and-other-bugs branch from 1c59495 to 7a391e5 Compare December 2, 2024 09:02
Copy link

github-actions bot commented Dec 2, 2024

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

Copy link

github-actions bot commented Dec 4, 2024

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@@ -0,0 +1,240 @@

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it is generated at build time, does it need to be in tree ?

and if the answer is yes, could you please add a comment on top of this file to explain what it is, thanks

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewliebenow ping ? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants