sort: add retry logic on file-descriptor exhaustion #7197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlmcdowall
force-pushed
the
sort_replace_file_copy
branch
from
f2af55a to
eadc90a
Compare
|
GNU testsuite comparison: |
|
I don't know if you have seen it, but it looks like your changes break the |
|
Yeah... I'll work on a fix, shouldn't take too long... |
karlmcdowall
force-pushed
the
sort_replace_file_copy
branch
2 times, most recently
from
ea1d1c3 to
5807deb
Compare
|
GNU testsuite comparison: |
karlmcdowall
force-pushed
the
sort_replace_file_copy
branch
2 times, most recently
from
dc92eb1 to
25c27ba
Compare
|
GNU testsuite comparison: |
karlmcdowall
force-pushed
the
sort_replace_file_copy
branch
2 times, most recently
from
ba1abb7 to
b35dda2
Compare
|
GNU testsuite comparison: |
karlmcdowall
force-pushed
the
sort_replace_file_copy
branch
from
b35dda2 to
b6731f7
Compare
|
GNU testsuite comparison: |
cakebaker
force-pushed
the
sort_replace_file_copy
branch
from
b6731f7 to
54800f2
Compare
|
GNU testsuite comparison: |
Partial fix for bug uutils#5714 Rework the merging logic to continue if we error-out due to file descriptor exhaustion. Merging will only stop if no progress can be made. Also minor tweek to code handling output-is-an-input scenario to prevent a double-open of the generated temp-file. Updated appropriate test case.
karlmcdowall
force-pushed
the
sort_replace_file_copy
branch
from
54800f2 to
12d3ed7
Compare
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for bug #5714
Rework the merging logic to continue if we error-out due to file descriptor exhaustion. Merging will only stop if no progress can be made.
Also minor tweek to code handling output-is-an-input scenario to prevent a double-open of the generated temp-file.
Updated appropriate test case.