Firebase auth branch #11
Open
+1,728
−197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lint lint
…/llsc into firebase-auth-branch
mmiqball
reviewed
Dec 1, 2024
| def role_based_access_control(allowed_roles: List[str]): | ||
| def middleware_decorator(endpoint: Callable): | ||
| async def wrapper(request: Request, *args, **kwargs): | ||
| roles = getattr(request.state, "user_roles", []) |
There was a problem hiding this comment.
it's much much safer to get a user's roles from firebase or the db ourselves using the methods in the auth service, instead of sending it in the request
imagine someone malicious adding in roles to their requests that they don't have access to, which would let them access other roles that they haven't been assigned to in the db
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notion ticket link
Ticket Name
Implementation description
Steps to test
What should reviewers focus on?
Checklist