#399 Add big object compiler flag #401
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrcomputing
commented
Feb 27, 2024
|
|
||
| if (CMAKE_CXX_COMPILER_ID STREQUAL "GNU") | ||
| #target_compile_options(${target} PRIVATE "-Wa,-mbig-obj") | ||
| set_source_files_properties(QskQml.cpp PROPERTIES COMPILE_FLAGS "-Wa,-mbig-obj") |
There was a problem hiding this comment.
@uwerat The first line adds the compiler options to the target, hence every cpp file. The second line adds it only to the problematic file.
vrcomputing
force-pushed
the
fix-mingw-file-too-big
branch
from
2b73982 to
37c68bd
Compare
vrcomputing
force-pushed
the
fix-mingw-file-too-big
branch
from
37c68bd to
b7380d7
Compare
|
@uwerat builds are green again, mergeable if still needed after your adaptions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #399