Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI layout fixes, improved flexibility, Swift 4.2 and more #94

Open
wants to merge 97 commits into
base: master
Choose a base branch
from
Open

UI layout fixes, improved flexibility, Swift 4.2 and more #94

Changes from 1 commit
Commits
Show all changes
97 commits
Select commit Hold shift + click to select a range
8128254
Initial upgrade to Swift 4.0
pushchris Aug 29, 2017
12c6773
Namespaces files to not conflict with PDFKit names (Fixes #71)
pushchris Sep 24, 2017
f64123c
make PDFRenderController in objective-c
prolok Oct 31, 2017
6d09e55
added special handling for signature mode
prolok Nov 1, 2017
07f4517
Make rightBarButtons() a bit more forgiving
scottcc Nov 6, 2017
c4e24d6
Fix rightBarButtons() and signatureMode
scottcc Nov 6, 2017
8f7f06c
Add autoSaveAction lazy closure var customization point
scottcc Nov 6, 2017
e8e91aa
Add readonly access to annotations
scottcc Nov 6, 2017
2e85fb8
Work around #76: Don't draw/annotate unless only one finger is used
scottcc Nov 7, 2017
b42592c
Allow setting a modalDoneButtonTouched block
scottcc Nov 13, 2017
896b371
start up a new annotation after undoing one
jakestephens Dec 6, 2017
491d394
Merge pull request #1 from jakestephens/master
scottcc Dec 6, 2017
9fc0082
ensure that the specified path width gets set
jakestephens Dec 12, 2017
41b81bc
make the undo button only active when there is something to undo
jakestephens Dec 12, 2017
c214cb8
Merge pull request #3 from jakestephens/master
jakestephens Dec 12, 2017
cc5dd51
fix it better
jakestephens Dec 12, 2017
8993564
Merge pull request #4 from jakestephens/master
jakestephens Dec 12, 2017
7484680
Swift upgrade to v4 -- Small bugfixes mostly regarding potential memo…
diegostamigni Jan 22, 2018
436a521
Update README.md
diegostamigni Jan 22, 2018
4057050
Update README.md
diegostamigni Jan 22, 2018
0525c79
dynamic safe area insets for bottom scrubber support added
diegostamigni Jan 26, 2018
504ea8c
iPhone X support added
diegostamigni Jan 26, 2018
f3a2582
Merge branch 'master' of github.com:diegostamigni/UXMPDFKit
diegostamigni Jan 26, 2018
64a6643
Toolbar icons updated (to a more iOS look and feel style) -- UXMThumb…
diegostamigni Feb 1, 2018
4207d0f
UXMPDFViewControllerDelegate protocol added
diegostamigni Feb 12, 2018
769606e
Fixes on multiple unnecessary UXMPDFViewControllerDelegate.editingDid…
diegostamigni Feb 12, 2018
0ec3cea
clearEncodedAnnotations utility method added (deletes serialized plis…
diegostamigni Feb 12, 2018
091dec6
- Added Signature annotation. Basically extended what was in the Sign…
brianmwadime Oct 3, 2018
50ad092
- handle device rotation for signature view
brianmwadime Oct 4, 2018
e13e382
- Fix display of signature after navigating away.
brianmwadime Oct 4, 2018
dffa51c
- Bump version.
brianmwadime Oct 4, 2018
759423b
- Fix keyboard hiding after textview editing.
brianmwadime Oct 4, 2018
fa3141f
Merge pull request #1 from Withinapp/feature/annotations
brianmwadime Oct 4, 2018
144d139
- Adds proper keyboard display for text form fields.
brianmwadime Oct 4, 2018
612fa09
Merge pull request #2 from Withinapp/feature/annotations
brianmwadime Oct 4, 2018
4c2e186
Fix delegate assignment for annotation actions.
brianmwadime Oct 4, 2018
e790408
Merge pull request #3 from Withinapp/feature/annotations
brianmwadime Oct 4, 2018
d358fdf
- return orientation back to portrait mode after signature is taken.
brianmwadime Oct 4, 2018
643ea93
Merge pull request #4 from Withinapp/feature/annotations
brianmwadime Oct 4, 2018
70f19ab
bump version.
brianmwadime Oct 4, 2018
b4a792b
- disable nabber hiding by default
brianmwadime Oct 4, 2018
6dbbc22
Fix orientation change for signature view
brianmwadime Oct 4, 2018
94908f0
Merge pull request #5 from Withinapp/feature/annotations
brianmwadime Oct 4, 2018
0e9bf2f
- Update signature rotation.
brianmwadime Oct 5, 2018
2582eb7
Merge pull request #6 from Withinapp/feature/annotations
brianmwadime Oct 5, 2018
2f88b4a
Fixes and upgrade to Swift 4
diegostamigni Nov 4, 2018
f85a9c0
Merge pull request #1 from diegostamigni/master
rivera-ernesto Dec 11, 2018
a261761
Merge remote-tracking branch 'withinapp/master' into fork
rivera-ernesto Dec 11, 2018
253b598
Update example project
rivera-ernesto Dec 11, 2018
92a3c8c
Remove dead alias
rivera-ernesto Dec 11, 2018
bb9b8c0
Update README
rivera-ernesto Dec 11, 2018
f400910
Remove deprecated .swift-version, use newer podspec’s swift_version
rivera-ernesto Dec 12, 2018
bdabe1b
Update Travis configuration to use Xcode 10.1 with Swift 4.2 support
rivera-ernesto Dec 12, 2018
ea07ae1
Merge pull request #2 from codelathe/master
diegostamigni Dec 12, 2018
9c3939d
Allow setting UXMPDFViewController’s document after loading its view
rivera-ernesto Dec 12, 2018
486276e
Cleanup Example project
rivera-ernesto Dec 17, 2018
7f792de
Call setNeedsLayout() instead of the not recommended layoutSubviews()
rivera-ernesto Dec 18, 2018
793d601
Use system Done button to dismiss controller in modal mode
rivera-ernesto Dec 18, 2018
bf5e9ea
Add pageScrubber’s height to single page viewer’s bottom inset
rivera-ernesto Dec 18, 2018
a87e327
Use adjustedContentInset to fix collection view layout warnings
rivera-ernesto Dec 18, 2018
da541f6
Fix UXMThumbnailView layout
rivera-ernesto Dec 18, 2018
ef32aba
Make pageScrubber an open variable
rivera-ernesto Dec 19, 2018
181e1ec
Fix page number positioning
rivera-ernesto Dec 19, 2018
062743a
New optional autoHidePageNumberTimeInterval
rivera-ernesto Dec 19, 2018
b6e557e
Rename annotations -> annotationsStore
rivera-ernesto Dec 20, 2018
277bc33
Add hasAnnotations computed variable to UXMAnnotationStore
rivera-ernesto Dec 20, 2018
fcfca54
Make autoSaveAction optional
rivera-ernesto Dec 20, 2018
a9afcb3
Make sure to call finishAnnotation() before showActivitySheet()
rivera-ernesto Dec 20, 2018
fdc15ab
Make save function use document.fileUrl when no URL is specified over…
rivera-ernesto Dec 20, 2018
e7ebf91
Refactor saveToPDFFile with optional overwriteOriginal parameter
rivera-ernesto Dec 20, 2018
5bf43c4
Update README.md
rivera-ernesto Dec 21, 2018
3dca33f
Update Swift version to 4.2
geankozen Jan 14, 2019
8dbfdbd
Update pod version
geankozen Jan 14, 2019
23d81ec
Fix recursivity crash
rivera-ernesto Jan 15, 2019
2ef7008
Only move saving files when needed
rivera-ernesto Jan 15, 2019
b0633be
Make UXMBarButton’s defaultTint public
rivera-ernesto Jan 15, 2019
0a03c17
Merge pull request #7 from diegostamigni/master
brianmwadime Feb 7, 2019
1c37ef9
Fix typo
rivera-ernesto Feb 12, 2019
7b7d978
Merge remote-tracking branch 'withinapp/master' into fork
rivera-ernesto Feb 12, 2019
79e871f
Merge branch 'fork'
rivera-ernesto Feb 15, 2019
7507847
Prevent crash when pdfDocRef.info is nil
rivera-ernesto Feb 15, 2019
75dd9d7
Make sure that `CGPDFDictionaryGetObject`’s object is not `nil`
rivera-ernesto Feb 15, 2019
aa3b2ff
Make sure that `renderPDF` receives a valid `size`
rivera-ernesto Feb 15, 2019
29ee597
Make `UXMPDFViewController`’s `collectionView` and `pageScrubber` opt…
rivera-ernesto Feb 15, 2019
afef159
Merge branch 'optionals' into fork
rivera-ernesto Feb 15, 2019
78843cb
More robust indexForPage() function
rivera-ernesto Feb 20, 2019
bf80e9c
Make sure to have a valid, non-empty PDF in displayPage() and getPage…
rivera-ernesto Feb 20, 2019
941bc16
Prevent crash when loading an empty PDF document
rivera-ernesto Feb 26, 2019
55547d0
Make sure to have an http or https scheme before opening PDF link wit…
rivera-ernesto Feb 26, 2019
6a0fe03
Prevent renderOntoPDF() crash when document has zero pages
rivera-ernesto Mar 1, 2019
010bc02
Merge branch 'fork'
rivera-ernesto Mar 12, 2019
c4dcee7
Prevet zoomReset() crash when minimumZoomScale == CGFloat.nan
rivera-ernesto Mar 21, 2019
22e296b
Do not force cast URL(string: stringUrl) in UXMActionURL’s init
rivera-ernesto Mar 21, 2019
1b201f5
Fix refreshScrubber() properly calling scrubberPageNumber() with inne…
rivera-ernesto Mar 21, 2019
4037971
Fix loadDocumentInformation’s setting of pageCount when pdfDocRef.inf…
rivera-ernesto Apr 2, 2019
d728e29
Do not restartTrackTimer on refreshScrubber
rivera-ernesto Apr 12, 2019
47f6ea4
Remove clipsToBounds from UXMPageContentView
rivera-ernesto Apr 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove clipsToBounds from UXMPageContentView
  • Loading branch information
@rivera-ernesto
rivera-ernesto committed Apr 12, 2019
commit 47f6ea45967ad66a032c096f4ed73cdf2342323d
2 changes: 1 addition & 1 deletion Pod/Classes/Renderer/UXMPageContentView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ open class UXMPageContentView: UIScrollView, UIScrollViewDelegate {
bouncesZoom = true
delegate = self
isScrollEnabled = true
clipsToBounds = true
clipsToBounds = false

autoresizingMask = [.flexibleHeight, .flexibleWidth]

Expand Down