Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: attempt to make Vite websocket tests more reliable #21078

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

mcollovati
Copy link
Collaborator

No description provided.

Copy link

github-actions bot commented Mar 4, 2025

Test Results

1 169 files  + 43  1 169 suites  +43   1h 13m 44s ⏱️ - 2m 35s
7 778 tests +305  7 721 ✅ +306  57 💤 ±0  0 ❌ ±0 
8 135 runs  +324  8 069 ✅ +323  66 💤 +2  0 ❌ ±0 

Results for commit 58682a3. ± Comparison against base commit bc40f5c.

♻️ This comment has been updated with latest results.

@mcollovati mcollovati force-pushed the test/vite_websocket_tests branch from 3b4a3fc to 58682a3 Compare March 5, 2025 11:09
@mcollovati mcollovati changed the title test: use custom executor for Vite websocket tests test: attempt to make Vite websocket tests more reliable Mar 5, 2025
@mcollovati
Copy link
Collaborator Author

mcollovati commented Mar 5, 2025

Rerun several times the unit tests job, and the ViteWebsocketConnection tests did not fail.
Hopefully, the change makes them more reliable

@mcollovati mcollovati marked this pull request as ready for review March 5, 2025 13:28
@mshabarov mshabarov merged commit 4ee3145 into main Mar 6, 2025
42 checks passed
@mshabarov mshabarov deleted the test/vite_websocket_tests branch March 6, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants