-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Bump sinon & chai #3035
chore: Bump sinon & chai #3035
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When updating versions of dependencies, it's probably better not to commit any package-lock.json
: those changes will happen thanks to the automated PRs and conflicts will be less frequent.
I took some smaller steps here #3041, maybe we should merge that first as it seems to work |
There seems to be one issue here:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3035 +/- ##
=======================================
Coverage 92.57% 92.57%
=======================================
Files 85 85
Lines 3166 3166
Branches 776 776
=======================================
Hits 2931 2931
Misses 183 183
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
... but apparently it works on CI |
Quality Gate passedIssues Measures |
No description provided.