Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump sinon & chai #3035

Merged
merged 2 commits into from
Dec 22, 2024
Merged

chore: Bump sinon & chai #3035

merged 2 commits into from
Dec 22, 2024

Conversation

Artur-
Copy link
Member

@Artur- Artur- commented Dec 17, 2024

No description provided.

Copy link
Contributor

@cromoteca cromoteca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When updating versions of dependencies, it's probably better not to commit any package-lock.json: those changes will happen thanks to the automated PRs and conflicts will be less frequent.

@Artur-
Copy link
Member Author

Artur- commented Dec 17, 2024

I took some smaller steps here #3041, maybe we should merge that first as it seems to work

@Artur-
Copy link
Member Author

Artur- commented Dec 19, 2024

There seems to be one issue here: filters correctly after changing model freezes the browser when it does

result.rerender(<AutoGrid service={_companyService} model={CompanyModel} />);

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.57%. Comparing base (ca313b9) to head (f39e567).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3035   +/-   ##
=======================================
  Coverage   92.57%   92.57%           
=======================================
  Files          85       85           
  Lines        3166     3166           
  Branches      776      776           
=======================================
  Hits         2931     2931           
  Misses        183      183           
  Partials       52       52           
Flag Coverage Δ
unittests 92.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Artur-
Copy link
Member Author

Artur- commented Dec 19, 2024

... but apparently it works on CI

@cromoteca cromoteca requested review from cromoteca and removed request for cromoteca December 20, 2024 15:24
@cromoteca cromoteca merged commit 7c4de5f into main Dec 22, 2024
15 checks passed
@cromoteca cromoteca deleted the sinon-chai branch December 22, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants