chore: Change the code so Eclipse JDT accepts it is ok #3072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3072 +/- ##
=======================================
Coverage 92.57% 92.57%
=======================================
Files 85 85
Lines 3166 3166
Branches 776 776
=======================================
Hits 2931 2931
Misses 183 183
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
taefi
requested changes
Dec 20, 2024
|
Updated description |
taefi
approved these changes
Dec 20, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Dec 20, 2024
taefi
pushed a commit
that referenced
this pull request
Dec 20, 2024
…4.6) (#3077) chore: Change the code so Eclipse JDT accepts it is ok (#3072) Co-authored-by: Artur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the project cannot be compiled in VS Code because it complains that
This is not a real error but a problem in the Eclipse compiler. his change makes the code compile also with VS Code / Eclipse