Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Vietnam holidays: add th localization #2060

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

PPsyrius
Copy link
Collaborator

Proposed change

Adds Thai (th) localization for Vietnam holidays.

Note

As there's no single official translation for Vietnamese Lunar New Year in Thai usage from the government (The Thai embassy in Ho Chi Minh city used English for their holiday's notice), I ended up using วันตรุษเต๊ต as used by the Voice of Vietnam and the Thai-Vietnamese Friendship Association over วันตรุษเวียตนาม and วันตรุษญวน.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

Copy link

sonarcloud bot commented Oct 17, 2024

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (bb25790) to head (6b2dc0d).

Additional details and impacted files
@@            Coverage Diff            @@
##               dev     #2060   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          190       190           
  Lines        11539     11539           
  Branches      1743      1743           
=========================================
  Hits         11539     11539           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant