Skip to content

Commit

Permalink
Bump to version 5.7.3
Browse files Browse the repository at this point in the history
  • Loading branch information
andreamazz committed May 11, 2021
1 parent 8726344 commit 86c2ef8
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 8 deletions.
2 changes: 1 addition & 1 deletion AMScrollingNavbar.podspec
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Pod::Spec.new do |s|
s.name = "AMScrollingNavbar"
s.version = "5.7.2"
s.version = "5.7.3"
s.summary = "A custom UINavigationController that enables the scrolling of the navigation bar alongside the scrolling of an observed content view"
s.description = <<-DESC
A custom UINavigationController that enables the scrolling of the
Expand Down
6 changes: 5 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
All notable changes to this project will be documented in this file.
`AMScrollingNavbar` adheres to [Semantic Versioning](http://semver.org/).

- `5.7.x` Releases - [5.7.0](#570) | [5.7.1](#571) | [5.7.2](#572)
- `5.7.x` Releases - [5.7.0](#570) | [5.7.1](#571) | [5.7.2](#572) | [5.7.3](#573)
- `5.6.x` Releases - [5.6.0](#560) | [5.6.1](#561)
- `5.5.x` Releases - [5.5.0](#550) | [5.5.1](#551) | [5.5.2](#552)
- `5.4.x` Releases - [5.4.0](#540) | [5.4.1](#541)
Expand All @@ -26,6 +26,10 @@ All notable changes to this project will be documented in this file.

---

## [5.7.3](https://github.com/andreamazz/AMScrollingNavbar/releases/tag/5.7.3)

- Fix issue introduced in #399

## [5.7.2](https://github.com/andreamazz/AMScrollingNavbar/releases/tag/5.7.2)

- Merged #401 (Thanks to [@feef](https://github.com/feef))
Expand Down
12 changes: 6 additions & 6 deletions Source/ScrollingNavigationController.swift
Original file line number Diff line number Diff line change
Expand Up @@ -650,17 +650,17 @@ open class ScrollingNavigationController: UINavigationController, UIGestureRecog

// Hide all the possible titles (See #398)
if #available(iOS 13.0, *) {
if let color = navigationBar.scrollEdgeAppearance?.titleTextAttributes [NSAttributedString.Key.foregroundColor] as? UIColor {
navigationBar.scrollEdgeAppearance?.titleTextAttributes [NSAttributedString.Key.foregroundColor] = color.withAlphaComponent(alpha)
if let color = navigationBar.scrollEdgeAppearance?.titleTextAttributes[NSAttributedString.Key.foregroundColor] as? UIColor {
navigationBar.scrollEdgeAppearance?.titleTextAttributes[NSAttributedString.Key.foregroundColor] = color.withAlphaComponent(alpha)
}

// NOTE: this breaks the tintColor, it's disabled for the time being
// if let color = navigationBar.standardAppearance.titleTextAttributes [NSAttributedString.Key.foregroundColor] as? UIColor {
// navigationBar.standardAppearance.titleTextAttributes [NSAttributedString.Key.foregroundColor] = color.withAlphaComponent(alpha)
// if let color = navigationBar.standardAppearance.titleTextAttributes[NSAttributedString.Key.foregroundColor] as? UIColor {
// navigationBar.standardAppearance.titleTextAttributes[NSAttributedString.Key.foregroundColor] = color.withAlphaComponent(alpha)
// }

if let color = navigationBar.compactAppearance?.titleTextAttributes [NSAttributedString.Key.foregroundColor] as? UIColor {
navigationBar.compactAppearance?.titleTextAttributes [NSAttributedString.Key.foregroundColor] = color.withAlphaComponent(alpha)
if let color = navigationBar.compactAppearance?.titleTextAttributes[NSAttributedString.Key.foregroundColor] as? UIColor {
navigationBar.compactAppearance?.titleTextAttributes[NSAttributedString.Key.foregroundColor] = color.withAlphaComponent(alpha)
}
}
navigationItem.titleView?.alpha = alpha
Expand Down

0 comments on commit 86c2ef8

Please sign in to comment.