Fix use after free error in test code

vcgato29 · Jul 31, 2017 · a79cb95 · a79cb95
1 parent 5ad4945
commit a79cb95
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/test/app/ValidatorSite_test.cpp b/src/test/app/ValidatorSite_test.cpp
@@ -125,10 +125,11 @@ class http_sync_server
     void
     on_accept(error_code ec)
     {
-        if(! acceptor_.is_open())
-            return;
-        if(ec)
+        // ec must be checked before `acceptor_` or the member variable may be
+        // accessed after the destructor has completed
+        if(ec || !acceptor_.is_open())
             return;
+
         static int id_ = 0;
         std::thread{lambda{++id_, *this, std::move(sock_)}}.detach();
         acceptor_.async_accept(sock_,