Skip to content

Commit

Permalink
SecurityPkg/Tcg: Fix various typos
Browse files Browse the repository at this point in the history
Fix various typos in documentation, comments and debug strings.

Cc: Jiewen Yao <[email protected]>
Cc: Jian J Wang <[email protected]>
Cc: Chao Zhang <[email protected]>
Signed-off-by: Antoine Coeur <[email protected]>
Reviewed-by: Philippe Mathieu-Daude <[email protected]>
Reviewed-by: Jiewen Yao <[email protected]>
Signed-off-by: Philippe Mathieu-Daude <[email protected]>
Message-Id: <[email protected]>
[[email protected]: replace EFI_D_xxx w/ DEBUG_xxx to shut up PatchCheck]
  • Loading branch information
Coeur authored and mergify[bot] committed Feb 10, 2020
1 parent f9fd0c2 commit dd40a1f
Show file tree
Hide file tree
Showing 14 changed files with 27 additions and 27 deletions.
4 changes: 2 additions & 2 deletions SecurityPkg/Include/Library/TcgStorageCoreLib.h
Original file line number Diff line number Diff line change
Expand Up @@ -588,7 +588,7 @@ TcgAddEndTransaction(
);

/**
Initial the tcg parse stucture.
Initial the tcg parse structure.
@param ParseStruct Input parse structure.
@param Buffer Input buffer data.
Expand Down Expand Up @@ -1218,7 +1218,7 @@ TcgParseSyncSession(
@param HostSession Host session data.
@param AceRow Ace row info.
@param Authority1 Authority 1 info.
@param LogicalOperator Logiccal operator info.
@param LogicalOperator Logical operator info.
@param Authority2 Authority 2 info.
@retval Return the action result.
Expand Down
2 changes: 1 addition & 1 deletion SecurityPkg/Library/TcgStorageCoreLib/TcgStorageCore.c
Original file line number Diff line number Diff line change
Expand Up @@ -837,7 +837,7 @@ TcgAddEndTransaction(
}

/**
Initial the tcg parse stucture.
Initial the tcg parse structure.
@param ParseStruct Input parse structure.
@param Buffer Input buffer data.
Expand Down
2 changes: 1 addition & 1 deletion SecurityPkg/Library/TcgStorageCoreLib/TcgStorageUtil.c
Original file line number Diff line number Diff line change
Expand Up @@ -640,7 +640,7 @@ TcgSetAuthorityEnabled(
@param HostSession Host session data.
@param AceRow Ace row info.
@param Authority1 Authority 1 info.
@param LogicalOperator Logiccal operator info.
@param LogicalOperator Logical operator info.
@param Authority2 Authority 2 info.
@retval Return the action result.
Expand Down
8 changes: 4 additions & 4 deletions SecurityPkg/Tcg/MemoryOverwriteControl/TcgMor.c
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ OnReadyToBoot (
Typically, there are 2 mechanism for resetting eDrive. They are:
1. TPer Reset through IEEE 1667 protocol.
2. TPer Reset through native TCG protocol.
This routine will detect what protocol the attached eDrive comform to, TCG or
This routine will detect what protocol the attached eDrive conform to, TCG or
IEEE 1667 protocol. Then send out TPer Reset command separately.
@param[in] Ssp The pointer to EFI_STORAGE_SECURITY_COMMAND_PROTOCOL instance.
Expand Down Expand Up @@ -109,7 +109,7 @@ InitiateTPerReset (
MediaId,
100000000, // Timeout 10-sec
0, // SecurityProtocol
0, // SecurityProtocolSpecifcData
0, // SecurityProtocolSpecificData
Len, // PayloadBufferSize,
Buffer, // PayloadBuffer
&XferSize
Expand Down Expand Up @@ -145,7 +145,7 @@ InitiateTPerReset (
MediaId,
100000000, // Timeout 10-sec
0, // SecurityProtocol
0, // SecurityProtocolSpecifcData
0, // SecurityProtocolSpecificData
Len, // PayloadBufferSize,
Buffer, // PayloadBuffer
&XferSize
Expand Down Expand Up @@ -197,7 +197,7 @@ InitiateTPerReset (
MediaId,
100000000, // Timeout 10-sec
SECURITY_PROTOCOL_TCG, // SecurityProtocol
0x0400, // SecurityProtocolSpecifcData
0x0400, // SecurityProtocolSpecificData
512, // PayloadBufferSize,
Buffer // PayloadBuffer
);
Expand Down
2 changes: 1 addition & 1 deletion SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c
Original file line number Diff line number Diff line change
Expand Up @@ -2583,7 +2583,7 @@ OpalDriverGetDriverDeviceName(
@param ImageHandle Image Handle this driver.
@param SystemTable Pointer to SystemTable.
@retval EFI_SUCCESS This function always complete successfully.
@retval EFI_SUCCESS This function always complete successfully.
**/
EFI_STATUS
EFIAPI
Expand Down
8 changes: 4 additions & 4 deletions SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.c
Original file line number Diff line number Diff line change
Expand Up @@ -1110,7 +1110,7 @@ OpalHiiGetBrowserData (
Set a string Value in a form.
@param DestStringId The stringid which need to update.
@param SrcAsciiStr The string nned to update.
@param SrcAsciiStr The string need to update.
@retval EFI_SUCCESS Do the required action success.
@retval Others Other error occur.
Expand Down Expand Up @@ -1164,7 +1164,7 @@ HiiSetFormString(
@param Dev The Opal device.
@retval EFI_SUCCESS Initialize the device success.
@retval EFI_SUCCESS Initialize the device success.
@retval EFI_DEVICE_ERROR Get info from device failed.
**/
Expand Down Expand Up @@ -1220,7 +1220,7 @@ OpalDiskInitialize (
@param OpalDisk The Opal device.
@retval EFI_SUCCESS Get ownership success.
@retval EFI_SUCCESS Get ownership success.
@retval EFI_ACCESS_DENIED Has send BlockSID command, can't change ownership.
@retval EFI_INVALID_PARAMETER Not get Msid info before get ownership info.
Expand Down Expand Up @@ -1254,7 +1254,7 @@ OpalDiskUpdateOwnerShip (
@param OpalDisk The Opal device.
@retval EFI_SUCCESS Initialize the device success.
@retval EFI_SUCCESS Initialize the device success.
@retval EFI_DEVICE_ERROR Get info from device failed.
@retval EFI_INVALID_PARAMETER Not get Msid info before get ownership info.
@retval EFI_ACCESS_DENIED Has send BlockSID command, can't change ownership.
Expand Down
6 changes: 3 additions & 3 deletions SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.h
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ GetDiskNameStringId(
@param OpalDisk The Opal device.
@retval EFI_SUCCESS Initialize the device success.
@retval EFI_SUCCESS Initialize the device success.
@retval EFI_DEVICE_ERROR Get info from device failed.
@retval EFI_INVALID_PARAMETER Not get Msid info before get ownership info.
Expand Down Expand Up @@ -348,7 +348,7 @@ HiiUninstall(
@param Dev The Opal device.
@retval EFI_SUCCESS Initialize the device success.
@retval EFI_SUCCESS Initialize the device success.
@retval EFI_DEVICE_ERROR Get info from device failed.
**/
Expand All @@ -362,7 +362,7 @@ OpalDiskInitialize (
@param OpalDisk The Opal device.
@retval EFI_SUCCESS Get ownership success.
@retval EFI_SUCCESS Get ownership success.
@retval EFI_ACCESS_DENIED Has send BlockSID command, can't change ownership.
@retval EFI_INVALID_PARAMETER Not get Msid info before get ownership info.
Expand Down
2 changes: 1 addition & 1 deletion SecurityPkg/Tcg/PhysicalPresencePei/PhysicalPresencePei.c
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ LockTpmPhysicalPresence (
);

//
// Global defintions for lock physical presence PPI and its descriptor.
// Global definitions for lock physical presence PPI and its descriptor.
//
PEI_LOCK_PHYSICAL_PRESENCE_PPI mLockPhysicalPresencePpi = {
LockTpmPhysicalPresence
Expand Down
2 changes: 1 addition & 1 deletion SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigPeim.c
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ Tcg2ConfigPeimEntryPoint (
ASSERT_EFI_ERROR (Status);

//
// Even if no TPM is selected or detected, we still need intall TpmInitializationDonePpi.
// Even if no TPM is selected or detected, we still need install TpmInitializationDonePpi.
// Because TcgPei or Tcg2Pei will not run, but we still need a way to notify other driver.
// Other driver can know TPM initialization state by TpmInitializedPpi.
//
Expand Down
4 changes: 2 additions & 2 deletions SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c
Original file line number Diff line number Diff line change
Expand Up @@ -1006,7 +1006,7 @@ PeimEntryMA (
}

//
// Only intall TpmInitializedPpi on success
// Only install TpmInitializedPpi on success
//
Status = PeiServicesInstallPpi (&mTpmInitializedPpiList);
ASSERT_EFI_ERROR (Status);
Expand All @@ -1027,7 +1027,7 @@ PeimEntryMA (
);
}
//
// Always intall TpmInitializationDonePpi no matter success or fail.
// Always install TpmInitializationDonePpi no matter success or fail.
// Other driver can know TPM initialization state by TpmInitializedPpi.
//
Status2 = PeiServicesInstallPpi (&mTpmInitializationDonePpiList);
Expand Down
2 changes: 1 addition & 1 deletion SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.uni
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// /** @file
// Provides ACPI metholds for TPM 2.0 support
// Provides ACPI methods for TPM 2.0 support
//
// This driver implements TPM 2.0 definition block in ACPI table and
// registers SMI callback functions for TCG2 physical presence and
Expand Down
8 changes: 4 additions & 4 deletions SecurityPkg/Tcg/TcgPei/TcgPei.c
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ EFI_PEI_NOTIFY_DESCRIPTOR mNotifyList[] = {
};

/**
Record all measured Firmware Voluem Information into a Guid Hob
Record all measured Firmware Volume Information into a Guid Hob
Guid Hob payload layout is
UINT32 *************************** FIRMWARE_BLOB number
Expand Down Expand Up @@ -501,7 +501,7 @@ MeasureMainBios (
}

/**
Measure and record the Firmware Voluem Information once FvInfoPPI install.
Measure and record the Firmware Volume Information once FvInfoPPI install.
@param[in] PeiServices An indirect pointer to the EFI_PEI_SERVICES table published by the PEI Foundation.
@param[in] NotifyDescriptor Address of the notification descriptor data structure.
Expand Down Expand Up @@ -824,7 +824,7 @@ PeimEntryMA (
}

//
// Only intall TpmInitializedPpi on success
// Only install TpmInitializedPpi on success
//
Status = PeiServicesInstallPpi (&mTpmInitializedPpiList);
ASSERT_EFI_ERROR (Status);
Expand All @@ -845,7 +845,7 @@ PeimEntryMA (
);
}
//
// Always intall TpmInitializationDonePpi no matter success or fail.
// Always install TpmInitializationDonePpi no matter success or fail.
// Other driver can know TPM initialization state by TpmInitializedPpi.
//
Status2 = PeiServicesInstallPpi (&mTpmInitializationDonePpiList);
Expand Down
2 changes: 1 addition & 1 deletion SecurityPkg/Tcg/TcgSmm/TcgSmm.inf
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
## @file
# Implements ACPI metholds for the TCG feature
# Implements ACPI methods for the TCG feature
#
# This driver implements TPM definition block in ACPI table and registers SMI
# callback functions for physical presence and MemoryClear to handle the requests
Expand Down
2 changes: 1 addition & 1 deletion SecurityPkg/Tcg/TcgSmm/TcgSmm.uni
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// /** @file
// Implements ACPI metholds for the TCG feature
// Implements ACPI methods for the TCG feature
//
// This driver implements TPM definition block in ACPI table and registers SMI
// callback functions for physical presence and MemoryClear to handle the requests
Expand Down

0 comments on commit dd40a1f

Please sign in to comment.