fix: remove TODO + show error message when reading/write in process p…

…rovider (WerWolv#1516)
venompb · Jan 26, 2024 · a4d6932 · a4d6932
1 parent d23d382
commit a4d6932
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/main/gui/source/messaging/win.cpp b/main/gui/source/messaging/win.cpp
@@ -45,8 +45,6 @@ namespace hex::messaging {
         HWND imHexWindow = *getImHexWindow();
 
         // Create the message
-        // TODO actually send all arguments and not just the eventName
-
         std::vector<u8> fulleventData(eventName.begin(), eventName.end());
         fulleventData.push_back('\0');
 

diff --git a/plugins/builtin/source/content/providers/process_memory_provider.cpp b/plugins/builtin/source/content/providers/process_memory_provider.cpp
@@ -63,7 +63,7 @@ namespace hex::plugin::builtin {
             auto read = process_vm_readv(m_processId, &local, 1, &remote, 1, 0);
 
             if (read == -1) {
-                // TODO error handling strerror(errno)
+                log::error("Process memory provider failed to read data: {}", strerror(errno));
             }
         #endif
     }
@@ -82,7 +82,7 @@ namespace hex::plugin::builtin {
 
             auto read = process_vm_writev(m_processId, &local, 1, &remote, 1, 0);
             if (read == -1) {
-                // TODO error handling strerror(errno)
+                log::error("Process memory provider failed to write data: {}", strerror(errno));
             }
         #endif
     }