Merge pull request backstage#6862 from kuangp/chore/UnregisterEntityD…

…ialog

chore(UnregisterEntityDialog): migrate to catalog-react

.changeset/seven-glasses-sit.md

@@ -0,0 +1,6 @@
+---
+'@backstage/plugin-catalog': patch
+'@backstage/plugin-catalog-react': patch
+---
+
+Migrate and export `UnregisterEntityDialog` component from `catalog-react` package

plugins/catalog-react/api-report.md

@@ -715,6 +715,17 @@ export function reduceEntityFilters(
 // @public (undocumented)
 export const rootRoute: RouteRef<undefined>;
 
+// Warning: (ae-forgotten-export) The symbol "Props" needs to be exported by the entry point index.d.ts
+// Warning: (ae-missing-release-tag) "UnregisterEntityDialog" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
+//
+// @public (undocumented)
+export const UnregisterEntityDialog: ({
+  open,
+  onConfirm,
+  onClose,
+  entity,
+}: Props_3) => JSX.Element;
+
 // Warning: (ae-missing-release-tag) "useEntity" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
 //
 // @public

plugins/catalog/src/components/UnregisterEntityDialog/UnregisterEntityDialog.test.tsx → plugins/catalog-react/src/components/UnregisterEntityDialog/UnregisterEntityDialog.test.tsx

@@ -21,7 +21,7 @@ import React from 'react';
 import { UnregisterEntityDialog } from './UnregisterEntityDialog';
 import { ORIGIN_LOCATION_ANNOTATION } from '@backstage/catalog-model';
 import { CatalogClient } from '@backstage/catalog-client';
-import { catalogApiRef } from '@backstage/plugin-catalog-react';
+import { catalogApiRef } from '../../api';
 import { screen, waitFor } from '@testing-library/react';
 import { renderInTestApp } from '@backstage/test-utils';
 import * as state from './useUnregisterEntityDialogState';

plugins/catalog/src/components/UnregisterEntityDialog/UnregisterEntityDialog.tsx → plugins/catalog-react/src/components/UnregisterEntityDialog/UnregisterEntityDialog.tsx

@@ -1,5 +1,5 @@
 /*
- * Copyright 2020 The Backstage Authors
+ * Copyright 2021 The Backstage Authors
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -15,7 +15,7 @@
  */
 
 import { Entity } from '@backstage/catalog-model';
-import { EntityRefLink } from '@backstage/plugin-catalog-react';
+import { EntityRefLink } from '../EntityRefLink';
 import {
   Box,
   Button,

plugins/catalog-react/src/components/UnregisterEntityDialog/index.ts

@@ -0,0 +1,17 @@
+/*
+ * Copyright 2021 The Backstage Authors
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+export { UnregisterEntityDialog } from './UnregisterEntityDialog';

plugins/catalog/src/components/UnregisterEntityDialog/useUnregisterEntityDialogState.test.tsx → plugins/catalog-react/src/components/UnregisterEntityDialog/useUnregisterEntityDialogState.test.tsx

@@ -19,7 +19,8 @@ import {
   Location,
   ORIGIN_LOCATION_ANNOTATION,
 } from '@backstage/catalog-model';
-import { CatalogApi, catalogApiRef } from '@backstage/plugin-catalog-react';
+import { CatalogApi } from '@backstage/catalog-client';
+import { catalogApiRef } from '../../api';
 import {
   act,
   renderHook,

plugins/catalog/src/components/UnregisterEntityDialog/useUnregisterEntityDialogState.ts → plugins/catalog-react/src/components/UnregisterEntityDialog/useUnregisterEntityDialogState.ts

@@ -20,7 +20,7 @@ import {
   getEntityName,
   ORIGIN_LOCATION_ANNOTATION,
 } from '@backstage/catalog-model';
-import { catalogApiRef } from '@backstage/plugin-catalog-react';
+import { catalogApiRef } from '../../api';
 import { useCallback } from 'react';
 import { useAsync } from 'react-use';
 import { useApi } from '@backstage/core-plugin-api';

plugins/catalog-react/src/components/index.ts

@@ -23,4 +23,5 @@ export * from './EntityTable';
 export * from './EntityTagPicker';
 export * from './EntityTypePicker';
 export * from './FavoriteEntity';
+export * from './UnregisterEntityDialog';
 export * from './UserListPicker';

plugins/catalog/src/components/EntityLayout/EntityLayout.tsx

@@ -39,14 +39,14 @@ import {
   EntityRefLinks,
   FavoriteEntity,
   getEntityRelations,
+  UnregisterEntityDialog,
   useEntityCompoundName,
 } from '@backstage/plugin-catalog-react';
 import { Box, TabProps } from '@material-ui/core';
 import { Alert } from '@material-ui/lab';
 import React, { useContext, useState } from 'react';
 import { useNavigate } from 'react-router';
 import { EntityContextMenu } from '../EntityContextMenu/EntityContextMenu';
-import { UnregisterEntityDialog } from '../UnregisterEntityDialog/UnregisterEntityDialog';
 
 type SubRoute = {
   path: string;

plugins/catalog/src/components/EntityPageLayout/EntityPageLayout.tsx

@@ -23,13 +23,13 @@ import {
   EntityRefLinks,
   FavoriteEntity,
   getEntityRelations,
+  UnregisterEntityDialog,
   useEntityCompoundName,
 } from '@backstage/plugin-catalog-react';
 import { Box } from '@material-ui/core';
 import React, { useContext, useState } from 'react';
 import { useNavigate } from 'react-router';
 import { EntityContextMenu } from '../EntityContextMenu/EntityContextMenu';
-import { UnregisterEntityDialog } from '../UnregisterEntityDialog/UnregisterEntityDialog';
 import { Tabbed } from './Tabbed';
 
 import {