feat(provider/amazon-bedrock): Add reasoning support #4980
+51
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Und3rf10w
changed the title
Und3rf10w
changed the title
|
Thank you! I will take a look at this soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds reasoning support for Claude models in Amazon Bedrock, as noted in issue #4977.
I have tested these changes in my environment, and confirmed that we receive reasoning in both streaming and non-streaming configurations.
In streaming and non-streaming, both the signature and reasoning text are properly extracted. You may want to convert this to use
providerOptionsinstead of relying onadditionalModelRequestFieldsinBedrockChatSettings, but I don't know the best practice for that.