Skip to content

Commit

Permalink
deprecation: Indicate that admin mutation GETs are deprecated. (envoy…
Browse files Browse the repository at this point in the history
…proxy#3001)

Signed-off-by: Joshua Marantz <[email protected]>
  • Loading branch information
jmarantz authored and mattklein123 committed Apr 5, 2018
1 parent 140dd03 commit 36eb9e7
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 3 deletions.
12 changes: 9 additions & 3 deletions DEPRECATED.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,13 @@ As of release 1.3.0, Envoy will follow a

The following features have been DEPRECATED and will be removed in the specified release cycle.

## Version 1.6.0
## Version 1.7.0 (pending)

* Admin mutations should be sent as POSTs rather than GETs. HTTP GETs will result in an error
status code and will not have their intended effect. Prior to 1.7, GETs can be used for
admin mutations, but a warning is logged.

## Version 1.6.0 (March 20, 2018)

* DOWNSTREAM_ADDRESS log formatter is deprecated. Use DOWNSTREAM_REMOTE_ADDRESS_WITHOUT_PORT
instead.
Expand All @@ -19,7 +25,7 @@ The following features have been DEPRECATED and will be removed in the specified
* `value` and `regex` fields in the `HeaderMatcher` message is deprecated. Use the `exact_match`
or `regex_match` oneof instead.

## Version 1.5.0
## Version 1.5.0.0 (Dec 4, 2017)

* The outlier detection `ejections_total` stats counter has been deprecated and not replaced. Monitor
the individual `ejections_detected_*` counters for the detectors of interest, or
Expand All @@ -29,7 +35,7 @@ The following features have been DEPRECATED and will be removed in the specified
* The outlier detection `ejections_success_rate` stats counter has been deprecated in favour of
`ejections_detected_success_rate` and `ejections_enforced_success_rate`.

## Version 1.4.0
## Version 1.4.0 (Aug 24, 2017)

* Config option `statsd_local_udp_port` has been deprecated and has been replaced with
`statsd_udp_ip_address`.
Expand Down
2 changes: 2 additions & 0 deletions GOVERNANCE.md
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,8 @@
to the next development release. E.g., "1.7.0-dev". At the same time, also add a new empty section
to the [release notes](https://github.com/envoyproxy/data-plane-api/blob/master/docs/root/intro/version_history.rst)
for the following version. E.g., "1.7.0".
* Update [DEPRECATED.md](DEPRECATED.md) to remove the '(pending)' comment on the current version,
replacing it with the release date. Add a placeholder for the next version.

## When does a maintainer lose maintainer status

Expand Down

0 comments on commit 36eb9e7

Please sign in to comment.