Merge pull request grafana#2060 from k6io/fix/1713-params-array-encoding

Fix array encoding in form data requests
vgopinathan · Jun 15, 2021 · 91bfc1c · 91bfc1c
2 parents 7daba1f + c7bb596
commit 91bfc1c
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/js/modules/k6/http/request.go b/js/modules/k6/http/request.go
@@ -177,6 +177,12 @@ func (h *HTTP) parseRequest(
 		if !requestContainsFile(data) {
 			bodyQuery := make(url.Values, len(data))
 			for k, v := range data {
+				if arr, ok := v.([]interface{}); ok {
+					for _, el := range arr {
+						bodyQuery.Add(k, formatFormVal(el))
+					}
+					continue
+				}
 				bodyQuery.Set(k, formatFormVal(v))
 			}
 			result.Body = bytes.NewBufferString(bodyQuery.Encode())

diff --git a/js/modules/k6/http/request_test.go b/js/modules/k6/http/request_test.go
@@ -1226,10 +1226,14 @@ func TestRequestAndBatch(t *testing.T) {
 
 			t.Run("object", func(t *testing.T) {
 				_, err := rt.RunString(fmt.Sprintf(sr(`
-				var res = http.%s("HTTPBIN_URL/%s", {a: "a", b: 2});
+				var equalArray = function(a, b) {
+					return a.length === b.length && a.every(function(v, i) { return v === b[i]});
+				}
+				var res = http.%s("HTTPBIN_URL/%s", {a: "a", b: 2, c: ["one", "two"]});
 				if (res.status != 200) { throw new Error("wrong status: " + res.status); }
 				if (res.json().form.a != "a") { throw new Error("wrong a=: " + res.json().form.a); }
 				if (res.json().form.b != "2") { throw new Error("wrong b=: " + res.json().form.b); }
+				if (!equalArray(res.json().form.c, ["one", "two"])) { throw new Error("wrong c: " + res.json().form.c); }
 				if (res.json().headers["Content-Type"] != "application/x-www-form-urlencoded") { throw new Error("wrong content type: " + res.json().headers["Content-Type"]); }
 				`), fn, strings.ToLower(method)))
 				assert.NoError(t, err)