-
-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maui winui master #373
Maui winui master #373
Conversation
# Conflicts: # src/LibVLCSharp.MAUI/Handlers/VideoViewHandler.cs
# Conflicts: # samples/LibVLCSharp.MAUI.Sample/MainViewModel.cs
Nice! I was just about to work on this myself! There is one more target that would be good to add: pure .Net 8 core. Adding this targetFramework would allow the lib to be added to XForms-style projects that don't use the shared-project style. I ran into this recently trying to add the libvlc-sharp.Maui package to a project I recently ported to Maui from XForms, and still has x-platform projects and platform-projects. The Maui-UI code is in a |
See this PR. I assume github is not the main repo, since this PR appears to have already been completed? |
Hi, thanks for your comments, will have a look at your PR shortly.
Didn't know that was supported by maui. Not sure how many projects will use that structure for maui projects but adding net8.0 shouldn't be a problem.
Main repo is indeed https://code.videolan.org/videolan/LibVLCSharp, but the github one is a mirror with the CI that runs on azure devops, because we (vlc) don't have windows runners and I need those :). PRs should be opened on GitHub to this repo 👍 |
Technically, it is not official, but this template pack makes it easier. I think it is useful for porting XForms projects -> Maui. Much easier than manually moving all the source files into new project structure. And, the Maui packages support .Netstandard2.0,2.1, and .Net8/9, so definitely supported, even if not using this template, can still put UI it's own .Net8/9/standard x-platform project. This has been the hardest part of porting things since most OSS Maui libs don't consider this scenario. Wish more did and also targeted .Netstandard, since that would make porting even easier. Since libvlcsharp has .NetStandard targets, libvlcSharp.Maui should be able to also target .NetStandard 2.0/1? I just thought about that. But I also understand why MS is only showing the shared-project style in examples to reduce the complexity of needing to understand DI and moving it to compile-time DI (a.k.a. multi-targeting). |
Understood, thanks for the details. I don't work on Xamarin/MAUI consumer apps anymore so did not know that :)
Yep, would that be useful to you? Not sure if that could cause tooling issues for consumers but probably not. |
No description provided.