Remove unnecessary clones when piping commands in hull (theseus-os#…

…1089) * Commands can take ownership of `previous_output` as they then overwrite it anyway. * The final command can take ownership of all streams. --------- Co-authored-by: Poxxy <[email protected]> Co-authored-by: Klim Tsoutsman <[email protected]>
vincentjzimmer · Jan 4, 2024 · ffb5e8b · ffb5e8b
1 parent 813015b
commit ffb5e8b
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/applications/hull/src/lib.rs b/applications/hull/src/lib.rs
@@ -188,10 +188,9 @@ impl Shell {
                     return result.map(|_| None);
                 } else {
                     let streams = IoStreams {
-                        // TODO: Technically clone not needed.
-                        stdin: previous_output.clone(),
-                        stdout: shell_streams.stdout.clone(),
-                        stderr: stderr.clone(),
+                        stdin: previous_output,
+                        stdout: shell_streams.stdout,
+                        stderr,
                         discipline: shell_streams.discipline,
                     };
                     let part = self.resolve_external(command, args, streams, job_id)?;
@@ -204,7 +203,7 @@ impl Shell {
 
             let pipe = Stdio::new();
             let streams = IoStreams {
-                stdin: previous_output.clone(),
+                stdin: previous_output,
                 stdout: Arc::new(pipe.get_writer()),
                 stderr: stderr.clone(),
                 discipline: None,