Skip to content

Commit

Permalink
Remove incorrect usage of AlertDialog.Builder.create
Browse files Browse the repository at this point in the history
AlertDialog.Builder.show() will create an AlertDialog before it show. This is the source code snippet:

        /**
         * Creates a {@link AlertDialog} with the arguments supplied to this builder and
         * {@link Dialog#show()}'s the dialog.
         */
        public AlertDialog show() {
            AlertDialog dialog = create();
            dialog.show();
            return dialog;
        }

github: close apache#96
  • Loading branch information
hadeslee authored and agrieve committed Mar 28, 2014
1 parent 9a00ccd commit b715d20
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions framework/src/org/apache/cordova/CordovaChromeClient.java
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,6 @@ public boolean onKey(DialogInterface dialog, int keyCode, KeyEvent event) {
return true;
}
});
dlg.create();
dlg.show();
return true;
}
Expand Down Expand Up @@ -188,7 +187,6 @@ public boolean onKey(DialogInterface dialog, int keyCode, KeyEvent event) {
return true;
}
});
dlg.create();
dlg.show();
return true;
}
Expand Down Expand Up @@ -280,7 +278,6 @@ public void onClick(DialogInterface dialog, int which) {
res.cancel();
}
});
dlg.create();
dlg.show();
}
return true;
Expand Down

0 comments on commit b715d20

Please sign in to comment.