Make is_charged_transaction safer

Returns False immediately if trans_id is 0 since this value means no record has been created and therefore the transaction can't have been charged.
virajshah · Jun 27, 2012 · fd4662a · fd4662a
1 parent 6f9f91e
commit fd4662a
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/r2/r2/lib/authorize/interaction.py b/r2/r2/lib/authorize/interaction.py
@@ -153,6 +153,7 @@ def void_transaction(user, trans_id, campaign, test = None):
 
 
 def is_charged_transaction(trans_id, campaign):
+    if not trans_id: return False # trans_id == 0 means no bid
     bid =  Bid.one(transaction = trans_id, campaign = campaign)
     return bid.is_charged()