fix PMD issue

Change-Id: I9a93051e19ac0bf178f0db2309e1ee65950661e0
virinchyp · Aug 15, 2013 · f1383b4 · f1383b4
1 parent ef83f50
commit f1383b4
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 10 deletions.
diff --git a/odata-api/src/main/java/com/sap/core/odata/api/ep/EntityProvider.java b/odata-api/src/main/java/com/sap/core/odata/api/ep/EntityProvider.java
@@ -339,7 +339,7 @@ public interface EntityProviderInterface {
      * @param boundary 
      * @return Batch Request as InputStream
      */
-    InputStream writeBatchRequestBody(List<BatchPart> batchParts, String boundary);
+    InputStream writeBatchRequest(List<BatchPart> batchParts, String boundary);
 
     /** 
      * Parse Batch Response body (as {@link InputStream}) and provide a list of single responses as {@link BatchSingleResponse}
@@ -711,8 +711,8 @@ public static ODataResponse writeBatchResponse(final List<BatchResponsePart> bat
    * @param boundary 
    * @return Batch Request as InputStream
    */
-  public static InputStream writeBatchRequestBody(final List<BatchPart> batchParts, final String boundary) {
-    return createEntityProvider().writeBatchRequestBody(batchParts, boundary);
+  public static InputStream writeBatchRequest(final List<BatchPart> batchParts, final String boundary) {
+    return createEntityProvider().writeBatchRequest(batchParts, boundary);
   }
 
   /** 

diff --git a/odata-core/src/main/java/com/sap/core/odata/core/batch/BatchRequestParser.java b/odata-core/src/main/java/com/sap/core/odata/core/batch/BatchRequestParser.java
@@ -341,8 +341,8 @@ private PathInfo parseRequestUri(final String uri) throws BatchException {
         pathInfo.setRequestUri(new URI(requestUri));
       }
       return pathInfo;
-    } catch (URISyntaxException e1) {
-      throw new BatchException(BatchException.INVALID_URI.addContent(currentLineNumber));
+    } catch (URISyntaxException e) {
+      throw new BatchException(BatchException.INVALID_URI.addContent(currentLineNumber), e);
     }
 
   }

diff --git a/odata-core/src/main/java/com/sap/core/odata/core/ep/ProviderFacadeImpl.java b/odata-core/src/main/java/com/sap/core/odata/core/ep/ProviderFacadeImpl.java
@@ -187,7 +187,7 @@ public ODataResponse writeBatchResponse(final List<BatchResponsePart> batchRespo
   }
 
   @Override
-  public InputStream writeBatchRequestBody(final List<BatchPart> batchParts, final String boundary) {
+  public InputStream writeBatchRequest(final List<BatchPart> batchParts, final String boundary) {
     BatchRequestWriter batchWriter = new BatchRequestWriter();
     return batchWriter.writeBatchRequest(batchParts, boundary);
   }

diff --git a/odata-fit/src/test/java/com/sap/core/odata/fit/client/ClientBatchTest.java b/odata-fit/src/test/java/com/sap/core/odata/fit/client/ClientBatchTest.java
@@ -40,7 +40,7 @@ public void testSimpleBatch() throws Exception {
     BatchPart request = BatchQueryPart.method(GET).uri("$metadata").build();
     batch.add(request);
 
-    InputStream body = EntityProvider.writeBatchRequestBody(batch, BOUNDARY);
+    InputStream body = EntityProvider.writeBatchRequest(batch, BOUNDARY);
     String batchRequestBody = StringHelper.inputStreamToString(body, true);
     checkMimeHeaders(batchRequestBody);
     checkBoundaryDelimiters(batchRequestBody);
@@ -80,7 +80,7 @@ public void testChangeSetBatch() throws Exception {
         .build();
     batch.add(request);
 
-    InputStream body = EntityProvider.writeBatchRequestBody(batch, BOUNDARY);
+    InputStream body = EntityProvider.writeBatchRequest(batch, BOUNDARY);
     String bodyAsString = StringHelper.inputStreamToString(body, true);
     checkMimeHeaders(bodyAsString);
     checkBoundaryDelimiters(bodyAsString);
@@ -140,7 +140,7 @@ public void testContentIdReferencing() throws Exception {
         .headers(getRequestHeaders).build();
     batch.add(request);
 
-    InputStream body = EntityProvider.writeBatchRequestBody(batch, BOUNDARY);
+    InputStream body = EntityProvider.writeBatchRequest(batch, BOUNDARY);
     String bodyAsString = StringHelper.inputStreamToString(body, true);
     checkMimeHeaders(bodyAsString);
     checkBoundaryDelimiters(bodyAsString);
@@ -176,7 +176,7 @@ public void testErrorBatch() throws Exception {
         .build();
     batch.add(request);
 
-    InputStream body = EntityProvider.writeBatchRequestBody(batch, BOUNDARY);
+    InputStream body = EntityProvider.writeBatchRequest(batch, BOUNDARY);
     String bodyAsString = StringHelper.inputStreamToString(body, true);
     checkMimeHeaders(bodyAsString);
     checkBoundaryDelimiters(bodyAsString);