Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
integration-build should fail when the build fails (TykTechnologies#3394
) Using the && construct masks a failure in the build even with set -e. Changed the format so that it fails instead of pushing an incomplete integration image to ECR. Also fixing incorrect files in `vendor/` ## How This Has Been Tested Tested by hand ## Screenshots (if appropriate) These were the errors due to vendor'd dependencies: ``` vendor/golang.org/x/sys/unix/zerrors_linux.go:163:1: syntax error: unexpected <<, expecting name vendor/golang.org/x/sys/unix/zerrors_linux.go:175:2: syntax error: non-declaration statement outside function body # golang.org/x/net/publicsuffix vendor/golang.org/x/net/publicsuffix/table.go:5:1: syntax error: non-declaration statement outside function body vendor/golang.org/x/net/publicsuffix/table.go:7:1: syntax error: non-declaration statement outside function body vendor/golang.org/x/net/publicsuffix/table.go:9:1: syntax error: non-declaration statement outside function body vendor/golang.org/x/net/publicsuffix/table.go:30:1: syntax error: non-declaration statement outside function body vendor/golang.org/x/net/publicsuffix/table.go:513:1: syntax error: non-declaration statement outside function body vendor/golang.org/x/net/publicsuffix/table.go:998:1: syntax error: non-declaration statement outside function body vendor/golang.org/x/net/publicsuffix/table.go:1018:1: syntax error: unexpected <<, expecting expression vendor/golang.org/x/net/publicsuffix/table.go:4635:49: syntax error: unexpected ) after top level declaration vendor/golang.org/x/net/publicsuffix/table.go:18958:1: syntax error: unexpected <<, expecting expression vendor/golang.org/x/net/publicsuffix/table.go:18984:49: syntax error: unexpected ) after top level declaration vendor/golang.org/x/net/publicsuffix/table.go:18984:49: too many errors ``` ## Types of changes <!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Refactoring or add test (improvements in base code or adds test coverage to functionality) ## Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply --> <!-- If you're unsure about any of these, don't hesitate to ask; we're here to help! --> - [x] Make sure you are requesting to **pull a topic/feature/bugfix branch** (right side). If pulling from your own fork, don't request your `master`! - [x] Make sure you are making a pull request against the **`master` branch** (left side). Also, you should start *your branch* off *our latest `master`*. - [ ] My change requires a change to the documentation. - [ ] If you've changed APIs, describe what needs to be updated in the documentation. - [ ] If new config option added, ensure that it can be set via ENV variable - [ ] I have updated the documentation accordingly. - [x] Modules and vendor dependencies have been updated; run `go mod tidy && go mod vendor` - [x] When updating library version must provide reason/explanation for this update. - [ ] I have added tests to cover my changes. - [x] All new and existing tests passed. - [x] Check your code additions will not fail linting checks: - [x] `go fmt -s` - [x] `go vet`
- Loading branch information
