sidekiq tests broke because of time-related bug in test #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ure. the hardcoded time specified is now in the past, so the test broke.
|
Hi, good catch :) I must say that personally I adore those kind of issues. Looks solid from my perspective. |
Marahin
approved these changes
Oct 6, 2020
|
What's the process for getting merged in? Curious just because this has been sitting approved for a few weeks now. :) |
|
Hi! This was approved 6 months ago. Should I be doing anything specific to move this forward? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Sidekiq test that was making sure
delay_untilwas working properly was queueing at a hardcoded2020-01-01.Sidekiq doesn't treat the job as a scheduled job if the scheduled time requested is in the past. This was causing an exception in the test.
This PR adjusts the test to always use a date in the future.