-
-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add arm64 support #906
base: master
Are you sure you want to change the base?
Add arm64 support #906
Conversation
@pat-s Thank you for your contribution! I think it can be useful for many people. |
Yes, debuginfo packages are optional, they make sense when installing perf (install_perl variable, false by default) |
@pat-s can we return the quotes as they were to minimize the amount of changes? |
Would you be ok with adding an editorconfig & prettier config to enforce these rules for editors with format-on-save enabled? This should then prevent similar cases in the future. |
Not surprising that some services don't have support yet giving the high amount you're wrapping here. And yes, the arm64 issue in Citus is still open. As most of these are rather optional and super crucial for the core support, listing these in a table so that arm64 interested people are aware should be enough? Would you mind checking on my previous comment so I can make the required adjustments? |
Yes, nevertheless, we strive to anticipate everything to minimize mistakes. If the Pigsty repository includes arm packages for citus, enabling the default repository should be sufficient. I’ll look into this separately.
I may not be an Ansible expert like you, but I thought double quotes were perfectly acceptable. I would appreciate it if you could share the correct settings to meet the best practices. We may also need to configure the linter to meet these requirements. |
It doesn't matter whether single or double quotes 🙃️. My question was: can I add an editorconfig file so that editors automatically uses double-quotes and don't apply these changes on save? (There are also linters for that but this is actually something else). This achieves two things: 1. I don't have to do a search & replace for all changes here and 2. Similar cases for other contributors won't occur as the editorconfig is in place. |
let's do this) I think it will help to adhere to one standard. |
It looks good, we need to perform thorough testing. |
fixes #866
I had to comment the install of the postgresql
debuginfo
packages as these are not avail for aarch64. Not sure if these are essential, I think they are rather optional?I've successfully deployed an arm64-only cluster on Alma9 with these changes.
Sorry for the quote changes, my editor autoformats and trims trailing whitespaces etc.