Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arm64 support #906

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Add arm64 support #906

wants to merge 20 commits into from

Conversation

pat-s
Copy link

@pat-s pat-s commented Mar 4, 2025

fixes #866

I had to comment the install of the postgresql debuginfo packages as these are not avail for aarch64. Not sure if these are essential, I think they are rather optional?

I've successfully deployed an arm64-only cluster on Alma9 with these changes.

Sorry for the quote changes, my editor autoformats and trims trailing whitespaces etc.

@vitabaks
Copy link
Owner

vitabaks commented Mar 5, 2025

@pat-s Thank you for your contribution! I think it can be useful for many people.

@vitabaks vitabaks added enhancement Improvement of the current functionality automation Automation functionality using Ansible labels Mar 5, 2025
@vitabaks
Copy link
Owner

vitabaks commented Mar 5, 2025

I had to comment the install of the postgresql debuginfo packages as these are not avail for aarch64. Not sure if these are essential, I think they are rather optional?

Yes, debuginfo packages are optional, they make sense when installing perf (install_perl variable, false by default)

@vitabaks
Copy link
Owner

vitabaks commented Mar 5, 2025

Sorry for the quote changes, my editor autoformats and trims trailing whitespaces etc.

@pat-s can we return the quotes as they were to minimize the amount of changes?

@pat-s
Copy link
Author

pat-s commented Mar 5, 2025

can we return the quotes as they were to minimize the amount of changes?

Would you be ok with adding an editorconfig & prettier config to enforce these rules for editors with format-on-save enabled? This should then prevent similar cases in the future.

@vitabaks
Copy link
Owner

vitabaks commented Mar 5, 2025

@pat-s I've made a few additional changes to support arm.

By the way, it looks like Timescale and Citus repo don't support arm packages for RHEL (TODO: check In pigsty repository)

@pat-s
Copy link
Author

pat-s commented Mar 5, 2025

Not surprising that some services don't have support yet giving the high amount you're wrapping here. And yes, the arm64 issue in Citus is still open.

As most of these are rather optional and super crucial for the core support, listing these in a table so that arm64 interested people are aware should be enough?

Would you mind checking on my previous comment so I can make the required adjustments?

@vitabaks
Copy link
Owner

vitabaks commented Mar 5, 2025

As most of these are rather optional and super crucial for the core support, listing these in a table so that arm64 interested people are aware should be enough?

Yes, nevertheless, we strive to anticipate everything to minimize mistakes. If the Pigsty repository includes arm packages for citus, enabling the default repository should be sufficient. I’ll look into this separately.

Would you mind checking on my previous comment so I can make the required adjustments?

I may not be an Ansible expert like you, but I thought double quotes were perfectly acceptable. I would appreciate it if you could share the correct settings to meet the best practices. We may also need to configure the linter to meet these requirements.

@pat-s
Copy link
Author

pat-s commented Mar 5, 2025

I may not be an Ansible expert like you, but I thought double quotes were perfectly acceptable. I would appreciate it if you could share the correct settings to meet the best practices. We may also need to configure the linter to meet these requirements.

It doesn't matter whether single or double quotes 🙃️.

My question was: can I add an editorconfig file so that editors automatically uses double-quotes and don't apply these changes on save? (There are also linters for that but this is actually something else).

This achieves two things: 1. I don't have to do a search & replace for all changes here and 2. Similar cases for other contributors won't occur as the editorconfig is in place.

@vitabaks
Copy link
Owner

vitabaks commented Mar 5, 2025

can I add an editorconfig file

let's do this) I think it will help to adhere to one standard.

@vitabaks
Copy link
Owner

vitabaks commented Mar 5, 2025

It looks good, we need to perform thorough testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation Automation functionality using Ansible enhancement Improvement of the current functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants