Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix increasesBy description #7121

Merged
merged 1 commit into from
Dec 24, 2024
Merged

Conversation

nopeless
Copy link
Contributor

@nopeless nopeless commented Dec 23, 2024

Description

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Dec 23, 2024

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 80dfa00
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/6769f4e6b033910008a7c3e2
😎 Deploy Preview https://deploy-preview-7121--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@hi-ogawa hi-ogawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we're missing types for increasesBy https://stackblitz.com/edit/vitest-dev-vitest-e6gktmra?file=test%2Fbasic.test.ts
This might be an issue in @types/chai. It would be great if you can fix the type too.

@hi-ogawa hi-ogawa merged commit b700d26 into vitest-dev:main Dec 24, 2024
8 checks passed
@nopeless
Copy link
Contributor Author

hi @hi-ogawa , the issue you have mentioned is not a @types/chai issue, but @vitest/expect using an outdated version of chai. I'm working on the fork to see if this is an easy fix issue.

@hi-ogawa
Copy link
Contributor

Good point, I just noticed we have chai v5 with @types/chai v4. It looks like mismatch was known when we bumped v5 #5135 (comment), but maybe it's time to update type too. Please feel free to try 👍

@nopeless nopeless deleted the patch-1 branch December 24, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants