Skip to content

Commit

Permalink
chore(listener): change the listener binding format 0.0.0.0:port to :…
Browse files Browse the repository at this point in the history
…port.
  • Loading branch information
zhongwencool committed Feb 8, 2022
1 parent f24c05b commit b50ceac
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion apps/emqx/src/emqx_listeners.erl
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,7 @@ merge_default(Options) ->
end.

format_addr(Port) when is_integer(Port) ->
io_lib:format("0.0.0.0:~w", [Port]);
io_lib:format(":~w", [Port]);
format_addr({Addr, Port}) when is_list(Addr) ->
io_lib:format("~ts:~w", [Addr, Port]);
format_addr({Addr, Port}) when is_tuple(Addr) ->
Expand Down
4 changes: 2 additions & 2 deletions apps/emqx_dashboard/src/emqx_dashboard.erl
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ start_listeners() ->
Minirest = BaseMinirest#{protocol => Protocol},
case minirest:start(Name, RanchOptions, Minirest) of
{ok, _} ->
?ULOG("Listener ~ts on ~ts started.~n", [Name, emqx_listeners:format_addr(Bind)]),
?ULOG("Start listener ~ts on ~p successfully.~n", [Name, emqx_listeners:format_addr(Bind)]),
Acc;
{error, _Reason} ->
%% Don't record the reason because minirest already does(too much logs noise).
Expand All @@ -82,7 +82,7 @@ stop_listeners() ->
[begin
case minirest:stop(Name) of
ok ->
?ULOG("Listener ~ts on ~ts stopped.~n", [Name, emqx_listeners:format_addr(Port)]);
?ULOG("Stop listener ~ts on ~p successfully.~n", [Name, emqx_listeners:format_addr(Port)]);
{error, not_found} ->
?SLOG(warning, #{msg => "stop_listener_failed", name => Name, port => Port})
end
Expand Down

0 comments on commit b50ceac

Please sign in to comment.