Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI][Spec Decode] fix: broken test for EAGLE model #11972

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

llsj14
Copy link
Contributor

@llsj14 llsj14 commented Jan 12, 2025

#11672 (comment)
here was an issue in the above PR that caused broken tests and a CI test omission.
This PR fixes the broken tests and updates the test pipeline.

test

As follows, broken unit tests were passed in my local environments.

pytest ./tests/spec_decode/e2e/test_eagle_correctness.py
========================================= test session starts ==========================================
platform linux -- Python 3.10.12, pytest-7.4.2, pluggy-1.3.0
rootdir: /mnt/lvm/sungjae/pr/vllm
configfile: pyproject.toml
plugins: asyncio-0.23.7, forked-1.6.0, anyio-3.7.1, hypothesis-5.35.1, flakefinder-1.1.0, rerunfailures-12.0, shard-0.1.2, xdist-3.3.1, xdoctest-1.0.2
asyncio: mode=strict
collected 15 items                                                                                     
Running 15 items in this shard

tests/spec_decode/e2e/test_eagle_correctness.py ...............                                  [100%]
=========================================== warnings summary ===========================================
…
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
============================= 15 passed, 17 warnings in 482.77s (0:08:02) ==============================

Signed-off-by: Sungjae Lee <[email protected]>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Jan 12, 2025
Signed-off-by: Sungjae Lee <[email protected]>
@@ -69,7 +74,8 @@ def __init__(self, *, vllm_config: VllmConfig, prefix: str = ""):

# Modify layer normalization and residual connections as suggested
# in the EAGLE framework: https://github.com/SafeAILab/EAGLE
self.model.model.layers[0].input_layernorm = DummyInputLayerNorm()
self.model.model.layers[0].input_layernorm = DummyInputLayerNorm(
weight=self.model.model.layers[0].input_layernorm.weight)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the standard EAGLE model checkpoint, this part is not necessary. However, the EAGLE model ("abhigoyal/vllm-eagle-llama-68m-random") used in spec_decode/e2e/test_eagle_correctness.py contains an input layernorm in its checkpoint. If I simply remove the weight in this DummyInputLayerNorm, it could cause errors when loading the model's weights.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Can you please add a comment on the need to have these weights for some of the unit tests that we have?

@llsj14
Copy link
Contributor Author

llsj14 commented Jan 12, 2025

@DarkLight1337
I just fixed the issues mentioned in this comment. Please take a look.

@DarkLight1337
Copy link
Member

Thanks for the quick fix! To avoid starting up a new CI instance just for this test, can you combine this with the speculative decoding CI?

Signed-off-by: Sungjae Lee <[email protected]>
@llsj14
Copy link
Contributor Author

llsj14 commented Jan 12, 2025

Thanks for the quick fix! To avoid starting up a new CI instance just for this test, can you combine this with the speculative decoding CI?

I was confused whether it was good or not to combine. Thank you for your feedbacks. I just updated it as you recommended.

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) January 12, 2025 15:26
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jan 12, 2025
Copy link
Collaborator

@sroy745 sroy745 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants