forked from uber/baseweb
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(slider): thumb should not render above select dropdown (uber#5215)
* fix(slider): thumb should not render above select dropdown * Update slider.tsx * test(vrt): update visual snapshots for 5ef14ab (uber#5216) Co-authored-by: UberOpenSourceBot <[email protected]>
- Loading branch information
1 parent
77488bc
commit ef11fd7
Showing
12 changed files
with
39 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
/* | ||
Copyright (c) Uber Technologies, Inc. | ||
This source code is licensed under the MIT license found in the | ||
LICENSE file in the root directory of this source tree. | ||
*/ | ||
import * as React from 'react'; | ||
|
||
import { Slider } from '..'; | ||
import { Select } from '../../select'; | ||
import type { Value } from '../../select'; | ||
|
||
export function Scenario() { | ||
const [value, setValue] = React.useState([25, 75]); | ||
const [selectValue, setSelectValue] = React.useState<Value>([]); | ||
|
||
return ( | ||
<> | ||
<Select | ||
options={[ | ||
{ label: 'AliceBlue', id: '#F0F8FF' }, | ||
{ label: 'AntiqueWhite', id: '#FAEBD7' }, | ||
{ label: 'Aqua', id: '#00FFFF' }, | ||
{ label: 'Aquamarine', id: '#7FFFD4' }, | ||
{ label: 'Azure', id: '#F0FFFF' }, | ||
{ label: 'Beige', id: '#F5F5DC' }, | ||
]} | ||
value={selectValue} | ||
placeholder="Select color" | ||
onChange={(params) => setSelectValue(params.value)} | ||
startOpen | ||
/> | ||
<Slider value={value} onChange={({ value }) => value && setValue(value)} /> | ||
</> | ||
); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+14.6 KB
vrt/tests.vrt.js-snapshots/slider--select-dropdown-dark-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+27.8 KB
vrt/tests.vrt.js-snapshots/slider--select-dropdown-dark-firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+30.4 KB
vrt/tests.vrt.js-snapshots/slider--select-dropdown-dark-webkit-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+15.9 KB
vrt/tests.vrt.js-snapshots/slider--select-dropdown-desktop-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+29.5 KB
vrt/tests.vrt.js-snapshots/slider--select-dropdown-desktop-firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+32.8 KB
vrt/tests.vrt.js-snapshots/slider--select-dropdown-desktop-webkit-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+13.1 KB
vrt/tests.vrt.js-snapshots/slider--select-dropdown-mobile-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+18.1 KB
vrt/tests.vrt.js-snapshots/slider--select-dropdown-mobile-firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+24.4 KB
vrt/tests.vrt.js-snapshots/slider--select-dropdown-mobile-webkit-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.