Make StringComparator deserialization case-insensitive (apache#3356)

vogali · Aug 12, 2016 · 4545878 · 4545878
1 parent 18af480
commit 4545878
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/processing/src/main/java/io/druid/query/ordering/StringComparator.java b/processing/src/main/java/io/druid/query/ordering/StringComparator.java
@@ -29,7 +29,7 @@ public abstract class StringComparator implements Comparator<String>
   @JsonCreator
   public static StringComparator fromString(String type)
   {
-    switch (type) {
+    switch (type.toLowerCase()) {
       case StringComparators.LEXICOGRAPHIC_NAME:
         return StringComparators.LEXICOGRAPHIC;
       case StringComparators.ALPHANUMERIC_NAME:

diff --git a/processing/src/test/java/io/druid/query/ordering/StringComparatorsTest.java b/processing/src/test/java/io/druid/query/ordering/StringComparatorsTest.java
@@ -207,5 +207,9 @@ public void testNumericComparatorSerdeTest() throws IOException
     String makeFromJsonSpec = "\"numeric\"";
     Assert.assertEquals(StringComparators.NUMERIC
         , jsonMapper.readValue(makeFromJsonSpec, StringComparator.class));
+
+    makeFromJsonSpec = "\"NuMeRiC\"";
+    Assert.assertEquals(StringComparators.NUMERIC
+        , jsonMapper.readValue(makeFromJsonSpec, StringComparator.class));
   }
 }