forked from apache/samza
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
SAMZA-2488: Add JobCoordinatorLaunchUtil to handle common logic when …
…launching job coordiantor. (apache#1318)
- Loading branch information
Showing
4 changed files
with
170 additions
and
84 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
81 changes: 81 additions & 0 deletions
81
samza-core/src/main/java/org/apache/samza/clustermanager/JobCoordinatorLaunchUtil.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,81 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.apache.samza.clustermanager; | ||
|
|
||
| import java.util.List; | ||
| import org.apache.samza.SamzaException; | ||
| import org.apache.samza.application.SamzaApplication; | ||
| import org.apache.samza.application.descriptors.ApplicationDescriptor; | ||
| import org.apache.samza.application.descriptors.ApplicationDescriptorImpl; | ||
| import org.apache.samza.application.descriptors.ApplicationDescriptorUtil; | ||
| import org.apache.samza.config.Config; | ||
| import org.apache.samza.config.JobConfig; | ||
| import org.apache.samza.coordinator.metadatastore.CoordinatorStreamStore; | ||
| import org.apache.samza.execution.RemoteJobPlanner; | ||
| import org.apache.samza.metadatastore.MetadataStore; | ||
| import org.apache.samza.metrics.MetricsRegistryMap; | ||
| import org.apache.samza.util.CoordinatorStreamUtil; | ||
| import org.apache.samza.util.DiagnosticsUtil; | ||
|
|
||
|
|
||
| /** | ||
| * Util class to launch and run {@link ClusterBasedJobCoordinator}. | ||
| * This util is being used by both high/low and beam API Samza jobs. | ||
| */ | ||
| public class JobCoordinatorLaunchUtil { | ||
| /** | ||
| * Run {@link ClusterBasedJobCoordinator} with full job config. | ||
| * | ||
| * @param app SamzaApplication to run. | ||
| * @param config full job config. | ||
| */ | ||
| @SuppressWarnings("rawtypes") | ||
| public static void run(SamzaApplication app, Config config) { | ||
| // Execute planning | ||
| ApplicationDescriptorImpl<? extends ApplicationDescriptor> | ||
| appDesc = ApplicationDescriptorUtil.getAppDescriptor(app, config); | ||
| RemoteJobPlanner planner = new RemoteJobPlanner(appDesc); | ||
| List<JobConfig> jobConfigs = planner.prepareJobs(); | ||
|
|
||
| if (jobConfigs.size() != 1) { | ||
| throw new SamzaException("Only support single remote job is supported."); | ||
| } | ||
|
|
||
| Config finalConfig = jobConfigs.get(0); | ||
|
|
||
| // This needs to be consistent with RemoteApplicationRunner#run where JobRunner#submit to be called instead of JobRunner#run | ||
| CoordinatorStreamUtil.writeConfigToCoordinatorStream(finalConfig, true); | ||
| DiagnosticsUtil.createDiagnosticsStream(finalConfig); | ||
| MetricsRegistryMap metrics = new MetricsRegistryMap(); | ||
| MetadataStore | ||
| metadataStore = new CoordinatorStreamStore(CoordinatorStreamUtil.buildCoordinatorStreamConfig(finalConfig), metrics); | ||
| // MetadataStore will be closed in ClusterBasedJobCoordinator#onShutDown | ||
| // initialization of MetadataStore can be moved to ClusterBasedJobCoordinator after we clean up | ||
| // ClusterBasedJobCoordinator#createFromMetadataStore | ||
| metadataStore.init(); | ||
|
|
||
| ClusterBasedJobCoordinator jc = new ClusterBasedJobCoordinator( | ||
| metrics, | ||
| metadataStore, | ||
| finalConfig); | ||
| jc.run(); | ||
| } | ||
|
|
||
| private JobCoordinatorLaunchUtil() {} | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
79 changes: 79 additions & 0 deletions
79
samza-core/src/test/java/org/apache/samza/clustermanager/TestJobCoordinatorLaunchUtil.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.apache.samza.clustermanager; | ||
|
|
||
| import java.util.Collections; | ||
| import java.util.HashMap; | ||
| import java.util.Map; | ||
| import org.apache.samza.application.MockStreamApplication; | ||
| import org.apache.samza.config.JobConfig; | ||
| import org.apache.samza.config.MapConfig; | ||
| import org.apache.samza.config.loaders.PropertiesConfigLoaderFactory; | ||
| import org.apache.samza.coordinator.metadatastore.CoordinatorStreamStore; | ||
| import org.apache.samza.execution.RemoteJobPlanner; | ||
| import org.apache.samza.metrics.MetricsRegistryMap; | ||
| import org.apache.samza.util.ConfigUtil; | ||
| import org.apache.samza.util.CoordinatorStreamUtil; | ||
| import org.junit.Test; | ||
| import org.junit.runner.RunWith; | ||
| import org.powermock.api.mockito.PowerMockito; | ||
| import org.powermock.core.classloader.annotations.PrepareForTest; | ||
| import org.powermock.modules.junit4.PowerMockRunner; | ||
|
|
||
| import static org.mockito.Matchers.any; | ||
| import static org.mockito.Matchers.eq; | ||
| import static org.mockito.Mockito.times; | ||
| import static org.mockito.Mockito.verify; | ||
| import static org.mockito.Mockito.when; | ||
| import static org.powermock.api.mockito.PowerMockito.mock; | ||
| import static org.powermock.api.mockito.PowerMockito.verifyNew; | ||
|
|
||
| @RunWith(PowerMockRunner.class) | ||
| @PrepareForTest({ | ||
| CoordinatorStreamUtil.class, | ||
| JobCoordinatorLaunchUtil.class, | ||
| CoordinatorStreamStore.class, | ||
| RemoteJobPlanner.class}) | ||
| public class TestJobCoordinatorLaunchUtil { | ||
| @Test | ||
| public void testCreateFromConfigLoader() throws Exception { | ||
| Map<String, String> config = new HashMap<>(); | ||
| config.put(JobConfig.CONFIG_LOADER_FACTORY, PropertiesConfigLoaderFactory.class.getName()); | ||
| config.put(PropertiesConfigLoaderFactory.CONFIG_LOADER_PROPERTIES_PREFIX + "path", | ||
| getClass().getResource("/test.properties").getPath()); | ||
| JobConfig originalConfig = new JobConfig(ConfigUtil.loadConfig(new MapConfig(config))); | ||
| JobConfig fullJobConfig = new JobConfig(new MapConfig(originalConfig, Collections.singletonMap("isAfterPlanning", "true"))); | ||
|
|
||
| RemoteJobPlanner mockJobPlanner = mock(RemoteJobPlanner.class); | ||
| CoordinatorStreamStore mockCoordinatorStreamStore = mock(CoordinatorStreamStore.class); | ||
| ClusterBasedJobCoordinator mockJC = mock(ClusterBasedJobCoordinator.class); | ||
|
|
||
| PowerMockito.mockStatic(CoordinatorStreamUtil.class); | ||
| PowerMockito.doReturn(new MapConfig()).when(CoordinatorStreamUtil.class, "buildCoordinatorStreamConfig", any()); | ||
| PowerMockito.whenNew(CoordinatorStreamStore.class).withAnyArguments().thenReturn(mockCoordinatorStreamStore); | ||
| PowerMockito.whenNew(RemoteJobPlanner.class).withAnyArguments().thenReturn(mockJobPlanner); | ||
| PowerMockito.whenNew(ClusterBasedJobCoordinator.class).withAnyArguments().thenReturn(mockJC); | ||
| when(mockJobPlanner.prepareJobs()).thenReturn(Collections.singletonList(fullJobConfig)); | ||
|
|
||
| JobCoordinatorLaunchUtil.run(new MockStreamApplication(), originalConfig); | ||
|
|
||
| verifyNew(ClusterBasedJobCoordinator.class).withArguments(any(MetricsRegistryMap.class), eq(mockCoordinatorStreamStore), eq(fullJobConfig)); | ||
| verify(mockJC, times(1)).run(); | ||
| } | ||
| } |