Fix broken retrieve method

vrana · Jun 2, 2011 · ece7221 · ece7221
1 parent 1aae623
commit ece7221
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 2 deletions.
diff --git a/src/stripe.php b/src/stripe.php
@@ -423,8 +423,8 @@ protected function ident() {
     return array($this['id']);
   }
 
-  public static function retrieve($id, $apiKey=null) {
-    $instance = new self($id, $apiKey);
+  protected static function scopedRetrieve($class, $id, $apiKey=null) {
+    $instance = new $class($id, $apiKey);
     $instance->refresh();
     return $instance;
   }
@@ -512,6 +512,11 @@ public static function constructFrom($values, $apiKey=null) {
     return self::scopedConstructFrom($class, $values, $apiKey);
   }
 
+  public static function retrieve($id, $apiKey=null) {
+    $class = get_class();
+    return self::scopedRetrieve($class, $id, $apiKey);
+  }
+
   public static function all($params=null, $apiKey=null) {
     $class = get_class();
     return self::scopedAll($class, $params, $apiKey);
@@ -537,6 +542,11 @@ public static function constructFrom($values, $apiKey=null) {
     return self::scopedConstructFrom($class, $values, $apiKey);
   }
 
+  public static function retrieve($id, $apiKey=null) {
+    $class = get_class();
+    return self::scopedRetrieve($class, $id, $apiKey);
+  }
+
   public static function all($params=null, $apiKey=null) {
     $class = get_class();
     return self::scopedAll($class, $params, $apiKey);
@@ -612,6 +622,11 @@ public static function constructFrom($values, $apiKey=null) {
     return self::scopedConstructFrom($class, $values, $apiKey);
   }
 
+  public static function retrieve($id, $apiKey=null) {
+    $class = get_class();
+    return self::scopedRetrieve($class, $id, $apiKey);
+  }
+
   public static function all($params=null, $apiKey=null) {
     $class = get_class();
     return self::scopedAll($class, $params, $apiKey);
@@ -631,6 +646,11 @@ public static function constructFrom($values, $apiKey=null) {
     return self::scopedConstructFrom($class, $values, $apiKey);
   }
 
+  public static function retrieve($id, $apiKey=null) {
+    $class = get_class();
+    return self::scopedRetrieve($class, $id, $apiKey);
+  }
+
   public static function all($params=null, $apiKey=null) {
     $class = get_class();
     return self::scopedAll($class, $params, $apiKey);

diff --git a/test/test_stripe.php b/test/test_stripe.php
@@ -96,6 +96,17 @@ public function testCreate() {
     $this->assertTrue($c->paid);
     $this->assertFalse($c->refunded);
   }
+
+  public function testRetrieve() {
+    authorizeFromEnv();
+    $c = StripeCharge::create(array('amount' => 100,
+				    'currency' => 'usd',
+				    'card' => array('number' => 4242424242424242,
+						    'exp_month' => 5,
+						    'exp_year' => 2015)));
+    $d = StripeCharge::retrieve($c->id);
+    $this->assertEqual($d->id, $c->id);
+  }
 }
 
 class TestCustomer extends UnitTestCase {