Merge pull request jashkenas#2609 from braddunbar/collection-create

Fix jashkenas#2606 - Collection#create success arguments.
vrinek · Jun 11, 2013 · bfc6d74 · bfc6d74
2 parents 4149557 + fa411d6
commit bfc6d74
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/backbone.js b/backbone.js
@@ -876,7 +876,7 @@
       if (!options.wait) this.add(model, options);
       var collection = this;
       var success = options.success;
-      options.success = function(resp) {
+      options.success = function(model, resp, options) {
         if (options.wait) collection.add(model, options);
         if (success) success(model, resp, options);
       };

diff --git a/test/collection.js b/test/collection.js
@@ -1142,4 +1142,15 @@ $(document).ready(function() {
     equal(collection.length, 2);
   });
 
+  test("#2606 - Collection#create, success arguments", 1, function() {
+    var collection = new Backbone.Collection;
+    collection.url = 'test';
+    collection.create({}, {
+      success: function(model, resp, options) {
+        strictEqual(resp, 'response');
+      }
+    });
+    this.ajaxSettings.success('response');
+  });
+
 });