Skip to content

Commit

Permalink
Merge branch 'main' into Rory-FixFlakyPodInstalls
Browse files Browse the repository at this point in the history
# Conflicts:
#	workflow_tests/assertions/platformDeployAssertions.ts
#	workflow_tests/assertions/testBuildAssertions.ts
  • Loading branch information
roryabraham committed Aug 8, 2024
2 parents 819c5ea + 4e690fd commit 49ddefa
Show file tree
Hide file tree
Showing 464 changed files with 10,390 additions and 24,892 deletions.
20 changes: 20 additions & 0 deletions .github/actions/composite/buildAndroidE2EAPK/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,9 @@ inputs:
EXPENSIFY_PARTNER_PASSWORD_EMAIL:
description: The email address of the Expensify partner to use for the build
required: true
SLACK_WEBHOOK_URL:
description: 'URL of the slack webhook'
required: true

runs:
using: composite
Expand Down Expand Up @@ -75,6 +78,23 @@ runs:
env:
RUBYOPT: '-rostruct'

- name: Announce failed workflow in Slack
if: failure()
uses: 8398a7/action-slack@v3
with:
status: custom
custom_payload: |
{
channel: '#e2e-announce',
attachments: [{
color: 'danger',
text: `🚧 ${process.env.AS_REPO} E2E APK build run failed on <https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}|${{ github.workflow }}> workflow 🚧`,
}]
}
env:
GITHUB_TOKEN: ${{ github.token }}
SLACK_WEBHOOK_URL: ${{ inputs.SLACK_WEBHOOK_URL }}

- name: Upload APK
uses: actions/upload-artifact@v4
with:
Expand Down
12 changes: 12 additions & 0 deletions .github/actions/javascript/checkReactCompiler/action.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
name: 'Check React compiler'
description: 'Compares two lists of compiled files and fails a job if previously successfully compiled files are no longer compiled successfully'
inputs:
OLD_LIST:
description: List of compiled files from the previous commit
required: true
NEW_LIST:
description: List of compiled files from the current commit
required: true
runs:
using: 'node20'
main: 'index.js'
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
/* eslint-disable @typescript-eslint/naming-convention */
import * as core from '@actions/core';

type ReactCompilerOutput = {
success: string[];
failure: string[];
};

const run = function (): Promise<void> {
const oldList = JSON.parse(core.getInput('OLD_LIST', {required: true})) as ReactCompilerOutput;
const newList = JSON.parse(core.getInput('NEW_LIST', {required: true})) as ReactCompilerOutput;

const errors: string[] = [];

oldList.success.forEach((file) => {
if (newList.success.includes(file) || !newList.failure.includes(file)) {
return;
}

errors.push(file);
});

if (errors.length > 0) {
errors.forEach((error) => console.error(error));
throw new Error(
'Some files could be compiled with react-compiler before successfully, but now they can not be compiled. Check https://github.com/Expensify/App/blob/main/contributingGuides/REACT_COMPILER.md documentation to see how you can fix this.',
);
}

return Promise.resolve();
};

if (require.main === module) {
run();
}

export default run;
Loading

0 comments on commit 49ddefa

Please sign in to comment.