Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useTemplateRef): don't update setup ref for useTemplateRef key #12756

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

edison1105
Copy link
Member

close #12749

Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB (+77 B) 38 kB (+32 B) 34.2 kB (-8 B)
vue.global.prod.js 158 kB (+77 B) 57.9 kB (+28 B) 51.5 kB (+30 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 46.5 kB (+77 B) 18.2 kB (+33 B) 16.7 kB (+20 B)
createApp 54.4 kB (+77 B) 21.2 kB (+32 B) 19.4 kB (+38 B)
createSSRApp 58.6 kB (+77 B) 22.9 kB (+28 B) 20.9 kB (+28 B)
defineCustomElement 59.2 kB (+77 B) 22.8 kB (+35 B) 20.7 kB (+27 B)
overall 68.4 kB (+77 B) 26.4 kB (+28 B) 24 kB (-13 B)

Copy link

pkg-pr-new bot commented Jan 21, 2025

Open in Stackblitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@12756

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@12756

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@12756

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@12756

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@12756

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@12756

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@12756

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@12756

@vue/shared

npm i https://pkg.pr.new/@vue/shared@12756

vue

npm i https://pkg.pr.new/vue@12756

@vue/compat

npm i https://pkg.pr.new/@vue/compat@12756

commit: e4208e4

@jh-leong
Copy link
Member

It seems this change might break an existing case: Playground

@edison1105 edison1105 added 🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. ready for review This PR requires more reviews labels Jan 21, 2025
@@ -125,4 +126,25 @@ describe('useTemplateRef', () => {
__DEV__ = true
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
}123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. ready for review This PR requires more reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong value when using useTemplateRef and defineModel
4 participants