chore(deps): update @vue/repl to version 4.6.0 #13470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThe changes update the "@vue/repl" dependency version in the SFC Playground package and enhance the Changes
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Size ReportBundles
Usages
|
@vue/compiler-core
@vue/compiler-dom
@vue/compiler-sfc
@vue/compiler-ssr
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/server-renderer
@vue/shared
vue
@vue/compat
commit: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages-private/sfc-playground/src/App.vue (1)
144-146: Props wired correctly; consider fall-back UI for unsupported versions
showSsrOutputis bound touseSSRMode(aref<boolean>), andshowOpenSourceMapis statically enabled—both match the API introduced in@vue/[email protected]. Looks good.One optional guard: if someone opens the playground with an older cached bundle of
@vue/replthe new props will be unknown and Vue will emit warnings. A simple defensive pattern:- <Repl + <Repl + v-bind="{ + showSsrOutput: useSSRMode, + showOpenSourceMap: true + }"keeps template clean and can be wrapped in a version check if needed later.
Otherwise, no issues.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (2)
packages-private/sfc-playground/package.json(1 hunks)packages-private/sfc-playground/src/App.vue(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: Redirect rules
- GitHub Check: Header rules
- GitHub Check: Pages changed
- GitHub Check: test / unit-test-windows
🔇 Additional comments (1)
packages-private/sfc-playground/package.json (1)
16-16:❓ Verification inconclusive
Verify lock-file & compatibility with new
@vue/replpropsBumping to
^4.6.0is required for the newshowSsrOutput/showOpenSourceMapprops, but please double-check:
pnpm-lock.yaml/package-lock.json/yarn.lockis updated so CI doesn’t pull4.5.x.@vue/[email protected]keeps the same peer-dependency range forvue—otherwise the localworkspace:*alias might be rejected.- No breaking API changes were introduced between 4.5.x → 4.6.0 that affect existing playground behaviour.
If you need a quick diff:
🏁 Script executed:
npm diff @vue/[email protected] @vue/[email protected] | lessLength of output: 871
🏁 Script executed:
#!/bin/bash set -e echo "🔍 Searching lockfiles for @vue/repl version..." rg "@vue/repl@" -n pnpm-lock.yaml package-lock.json yarn.lock || echo "No @vue/repl entries found in lockfiles." echo echo "📦 Peer dependencies for @vue/[email protected]:" npm view @vue/[email protected] peerDependencies --json || echo "Fetch failed for 4.5.1" echo echo "📦 Peer dependencies for @vue/[email protected]:" npm view @vue/[email protected] peerDependencies --json || echo "Fetch failed for 4.6.0"Length of output: 763
🏁 Script executed:
#!/bin/bash set -e echo "🔍 Peer dependency for 'vue' in @vue/[email protected]:" npm view @vue/[email protected] peerDependencies.vue --json || echo "none" echo echo "🔍 Peer dependency for 'vue' in @vue/[email protected]:" npm view @vue/[email protected] peerDependencies.vue --json || echo "none"Length of output: 352
Lockfile & Peer-Dependency Check
- ✅ pnpm-lock.yaml now includes
@vue/[email protected](no leftover 4.5.x entries).- ✅ Running
npm view @vue/[email protected] peerDependenciesshows the samevuerange as 4.5.x (no change).- 🧐 Although this is a minor bump (no semver-major), please give the playground a quick smoke test to ensure
showSsrOutput/showOpenSourceMapwork as expected and that no unintended API changes slipped in:npm diff --diff @vue/[email protected] --diff @vue/[email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Chores