Skip to content

test(runtime-vapor): add vdomInterop tests #13563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 4, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 55 additions & 2 deletions packages/runtime-vapor/__tests__/_utils.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { createVaporApp } from '../src'
import type { App } from '@vue/runtime-dom'
import { createVaporApp, vaporInteropPlugin } from '../src'
import { type App, type Component, createApp } from '@vue/runtime-dom'
import type { VaporComponent, VaporComponentInstance } from '../src/component'
import type { RawProps } from '../src/componentProps'

Expand Down Expand Up @@ -82,3 +82,56 @@ export function makeRender<C = VaporComponent>(

return define
}

export interface InteropRenderContext {
mount: (container?: string | ParentNode) => InteropRenderContext
render: (
props?: RawProps,
container?: string | ParentNode,
) => InteropRenderContext
host: HTMLElement
html: () => string
}

export function makeInteropRender(): (comp: Component) => InteropRenderContext {
let host: HTMLElement
beforeEach(() => {
host = document.createElement('div')
})
afterEach(() => {
host.remove()
})

function define(comp: Component) {
let app: App
function render(
props: RawProps | undefined = undefined,
container: string | ParentNode = host,
) {
app?.unmount()
app = createApp(comp, props)
app.use(vaporInteropPlugin)
return mount(container)
}

function mount(container: string | ParentNode = host) {
app.mount(container)
return res()
}

function html() {
return host.innerHTML
}

const res = () => ({
host,
mount,
render,
html,
})

return res()
}

return define
}
48 changes: 1 addition & 47 deletions packages/runtime-vapor/__tests__/componentAttrs.spec.ts
Original file line number Diff line number Diff line change
@@ -1,11 +1,4 @@
import {
type Ref,
createApp,
defineComponent,
h,
nextTick,
ref,
} from '@vue/runtime-dom'
import { type Ref, nextTick, ref } from '@vue/runtime-dom'
import {
createComponent,
createDynamicComponent,
Expand All @@ -17,7 +10,6 @@ import {
setProp,
setStyle,
template,
vaporInteropPlugin,
} from '../src'
import { makeRender } from './_utils'
import { stringifyStyle } from '@vue/shared'
Expand Down Expand Up @@ -407,42 +399,4 @@ describe('attribute fallthrough', () => {
const el = host.children[0]
expect(el.classList.length).toBe(0)
})

it('should not fallthrough emit handlers to vdom child', () => {
const VDomChild = defineComponent({
emits: ['click'],
setup(_, { emit }) {
return () => h('button', { onClick: () => emit('click') }, 'click me')
},
})

const fn = vi.fn()
const VaporChild = defineVaporComponent({
emits: ['click'],
setup() {
return createComponent(
VDomChild as any,
{ onClick: () => fn },
null,
true,
)
},
})

const App = {
setup() {
return () => h(VaporChild as any)
},
}

const root = document.createElement('div')
createApp(App).use(vaporInteropPlugin).mount(root)

expect(root.innerHTML).toBe('<button>click me</button>')
const button = root.querySelector('button')!
button.dispatchEvent(new Event('click'))

// fn should be called once
expect(fn).toHaveBeenCalledTimes(1)
})
})
58 changes: 58 additions & 0 deletions packages/runtime-vapor/__tests__/vdomInterop.spec.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
import { defineComponent, h } from '@vue/runtime-dom'
import { makeInteropRender } from './_utils'
import { createComponent, defineVaporComponent } from '../src'

const define = makeInteropRender()

describe('vdomInterop', () => {
describe.todo('props', () => {})

describe.todo('emit', () => {})

describe.todo('slots', () => {})

describe.todo('provide', () => {})

describe.todo('inject', () => {})

describe.todo('template ref', () => {})

describe.todo('dynamic component', () => {})

describe('attribute fallthrough', () => {
it('should not fallthrough emit handlers to vdom child', () => {
const VDomChild = defineComponent({
emits: ['click'],
setup(_, { emit }) {
return () => h('button', { onClick: () => emit('click') }, 'click me')
},
})

const fn = vi.fn()
const VaporChild = defineVaporComponent({
emits: ['click'],
setup() {
return createComponent(
VDomChild as any,
{ onClick: () => fn },
null,
true,
)
},
})

const { host, html } = define({
setup() {
return () => h(VaporChild as any)
},
}).render()

expect(html()).toBe('<button>click me</button>')
const button = host.querySelector('button')!
button.dispatchEvent(new Event('click'))

// fn should be called once
expect(fn).toHaveBeenCalledTimes(1)
})
})
})