Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Promise rejection in guards (fix #2833) #2838

Closed
wants to merge 12 commits into from
Closed

Handle Promise rejection in guards (fix #2833) #2838

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
7e1b1f7
chore(babel): support async/await, add transform-runtime
oleksiikhr Jun 30, 2019
9bb5f1b
fix: thrown async/await on router.onError
oleksiikhr Jun 30, 2019
2a36de2
chore(test): coverage async router.beforeEach
oleksiikhr Jun 30, 2019
5dcda8b
chore(revert): remove babel transform-runtime
oleksiikhr Jun 30, 2019
d8d2286
chore: rewrite async/await to promise
oleksiikhr Jun 30, 2019
f00d600
chore: add example template for error-handling
oleksiikhr Jun 30, 2019
58e4d6f
chore: add more components for error-handling demo
oleksiikhr Jun 30, 2019
283ca28
chore: update support async/await for guard
oleksiikhr Jun 30, 2019
843689d
chore: set asyncMode default true
oleksiikhr Jun 30, 2019
e8b4024
chore(test): coverage async/await - beforeEach, afterEach, beforeResolve
oleksiikhr Jun 30, 2019
8cd27c0
chore(test): add e2e for error-handling demo
oleksiikhr Jul 1, 2019
3b763e0
chore(test): change name of runner
oleksiikhr Jul 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: set asyncMode default true
  • Loading branch information
@oleksiikhr
oleksiikhr committed Jun 30, 2019
commit 843689dcc5a48f4d6aa2ec386220d9894bcdf3d6
6 changes: 3 additions & 3 deletions examples/error-handling/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import VueRouter from 'vue-router'
Vue.use(VueRouter)

// eslint-disable-next-line no-unused-vars
let asyncMode = false
let asyncMode = true

const makeError = (msg) => {
if (asyncMode) {
Expand Down Expand Up @@ -96,7 +96,7 @@ new Vue({
router,
data () {
return {
asyncMode: false
asyncMode
}
},
watch: {
Expand All @@ -107,7 +107,7 @@ new Vue({
template: `
<div id="app">
<h1>Error Handling</h1>
<strong @click="asyncMode = !asyncMode">
<strong @click="asyncMode = !asyncMode" style="cursor: pointer">
Open console - <code>{{ asyncMode ? 'async' : 'sync' }} (click)</code>
</strong>
<br>
Expand Down