Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct typedef of Route #3901

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Conversation

aryanbhosale
Copy link

Fixes #3566

updated typedef of interface Route from query: Dictionary<string | (string | null)[]> to query: Dictionary<string | null | (string | null)[]>

Copy link

netlify bot commented Aug 25, 2024

Deploy Preview for vue-router-docs-v3 canceled.

Name Link
🔨 Latest commit dee25cf
🔍 Latest deploy log https://app.netlify.com/sites/vue-router-docs-v3/deploys/66cdaf9e95579c000874784d

Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test?

@aryanbhosale
Copy link
Author

Can you add a test?

Which files exactly? im kinda new to this so just the files that need to be covered would be great

@posva
Copy link
Member

posva commented Aug 26, 2024

You can add it here: https://github.com/vuejs/vue-router/tree/dev/types/test

@aryanbhosale
Copy link
Author

You can add it here: https://github.com/vuejs/vue-router/tree/dev/types/test

Thank you! Will have a look

@aryanbhosale
Copy link
Author

You can add it here: https://github.com/vuejs/vue-router/tree/dev/types/test

is my latest commit what you were looking for in the test?

@posva
Copy link
Member

posva commented Aug 28, 2024

Thanks! That should be the test. I will take a look on my next pass over vue router 3.

@aryanbhosale aryanbhosale requested a review from posva August 28, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The type definition of Route seems to be partially wrong
2 participants