-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #9847 Add shouldRenderAsyncScripts option #10794
base: dev
Are you sure you want to change the base?
Fix #9847 Add shouldRenderAsyncScripts option #10794
Conversation
Provide a new option (shouldRenderAsyncScripts) to render or not async scripts in TemplateRenderer fix vuejs#9847
@yyx990803 Please look to this at affection 🙏 😍 |
Hi guys, this is super important for performance. Do we have any ETA? Thanks :) |
Would be really great to see this one pushed through, this feature is very important to reduce Javascript load in front end, which will be a big boost to SEO |
Any update on when this feature will be available? |
+1 for this - would speed out Vue/Nuxt applications greatly. Any updates on when somebody pushes the merge button? |
C'mon guys @jeanphilippeds did all the hard work on this one, it shouldn't even be that hard a merge as it's an optional boolean, can we get this in soon? |
Can we merge this please? <3 |
WE WANT THIS! WE WANT THIS! WE WANT THIS! WE WANT THIS! |
PLEASE <3 |
please |
yeah this would allow great performance improvements! |
For everyone who is using nuxt, here is a workaround: #9847 (comment) |
@yyx990803 @posva @Akryum @Kingwl @LinusBorg Can we merge it please ? 🙏 @jeanphilippeds Did a very usefull work here ! |
I wonder what's keeping us from merging this with latest release? How can I help? |
Guys, any news? how can we help? Sice google Web Vitals now scan more for unused code, this would help greatly. |
We currently focus all our efforts on bringing Vue 3 and its supor libs into RC stage. Please understand that we currently have less bandwidth for Vue 2, and improvements such as this are currenty not a the very top of the list. We will ge back to Vue 2 and do a round of bug fixes and improvements as soon as our bandwidth allows. |
@LinusBorg Fully understandable. Can't wait for vue 3. However, is this fix expected to hit Vue 3 as well? |
Man, this is killing me waiting for this! @jeanphilippeds, well done! Gutted it still hasn't made it's way in 7 months later |
Hi, @LinusBorg, any progress on this? We are still waiting. It is even harder to get nice score after last PageSpeed Insights update. |
Hi guys, there are still projects on Vue 2, can someone merge this, please? It really became a problem with new versions of Google Lighthouse. |
can we merge this please? |
How can I help getting this merged? |
Is there any chance that this RP will be merged, as it has been over 3 years now. |
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
dev
branch for v2.x (or to a previous version branch), not themaster
branchfix #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: