Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #9847 Add shouldRenderAsyncScripts option #10794

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

jeanphilippeds
Copy link

@jeanphilippeds jeanphilippeds commented Nov 4, 2019

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

JP added 2 commits November 4, 2019 15:42
Provide a new option (shouldRenderAsyncScripts) to render or not async scripts in TemplateRenderer

fix vuejs#9847
@AGPDev
Copy link

AGPDev commented Nov 9, 2019

@yyx990803 Please look to this at affection 🙏 😍

@fibigerg
Copy link

Hi guys, this is super important for performance. Do we have any ETA? Thanks :)

@posva posva added the feat:ssr label Feb 13, 2020
@paulsharratt0
Copy link

Would be really great to see this one pushed through, this feature is very important to reduce Javascript load in front end, which will be a big boost to SEO

@Moncef12
Copy link

Any update on when this feature will be available?
We are using lazy hydration it will be a huge plus to not load the not needed bundles at first.

@simplenotezy
Copy link

+1 for this - would speed out Vue/Nuxt applications greatly. Any updates on when somebody pushes the merge button?

@paulsharratt0
Copy link

C'mon guys @jeanphilippeds did all the hard work on this one, it shouldn't even be that hard a merge as it's an optional boolean, can we get this in soon?

@Tantawi
Copy link

Tantawi commented Mar 21, 2020

Can we merge this please? <3

@asennoussi
Copy link

WE WANT THIS! WE WANT THIS! WE WANT THIS! WE WANT THIS!
WE WANT THIS! WE WANT THIS! WE WANT THIS! WE WANT THIS!

@fibigerg
Copy link

PLEASE <3

@NinthAutumn
Copy link

please

@dotBits
Copy link

dotBits commented May 15, 2020

yeah this would allow great performance improvements!

@simllll
Copy link

simllll commented May 15, 2020

For everyone who is using nuxt, here is a workaround: #9847 (comment)

@quentinlagache
Copy link

quentinlagache commented Jun 4, 2020

@yyx990803 @posva @Akryum @Kingwl @LinusBorg Can we merge it please ? 🙏

@jeanphilippeds Did a very usefull work here !

@simplenotezy
Copy link

I wonder what's keeping us from merging this with latest release? How can I help?

@Darwex
Copy link

Darwex commented Jun 9, 2020

Guys, any news? how can we help? Sice google Web Vitals now scan more for unused code, this would help greatly.

@LinusBorg
Copy link
Member

We currently focus all our efforts on bringing Vue 3 and its supor libs into RC stage.

Please understand that we currently have less bandwidth for Vue 2, and improvements such as this are currenty not a the very top of the list.

We will ge back to Vue 2 and do a round of bug fixes and improvements as soon as our bandwidth allows.

@simplenotezy
Copy link

@LinusBorg Fully understandable. Can't wait for vue 3. However, is this fix expected to hit Vue 3 as well?

@spacedawwwg
Copy link

Man, this is killing me waiting for this!

@jeanphilippeds, well done! Gutted it still hasn't made it's way in 7 months later

@fibigerg
Copy link

Hi, @LinusBorg, any progress on this? We are still waiting. It is even harder to get nice score after last PageSpeed Insights update.

@fibigerg
Copy link

Hi guys, there are still projects on Vue 2, can someone merge this, please? It really became a problem with new versions of Google Lighthouse.

@alexander-schneider
Copy link

can we merge this please?

@coffeeneed
Copy link

How can I help getting this merged?

@lateek35
Copy link

Is there any chance that this RP will be merged, as it has been over 3 years now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.