Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types(Vue.use): fix #10573, better Vue.use type inference #11351

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

IWANABETHATGUY
Copy link

@IWANABETHATGUY IWANABETHATGUY commented Apr 27, 2020

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@IWANABETHATGUY
Copy link
Author

Fix the same problem as #10575, but a more understandable way, offer more accurate type inference and completion for plugin .
Closes #10573

@IWANABETHATGUY
Copy link
Author

current Vue.use for a PluginFunction, wrong type inference and no type checking.
image
this pr version , type checking is effective and we could get relevant completion
image
image

@IWANABETHATGUY IWANABETHATGUY changed the title fix(plugin-test.ts): fix #10573 types(Vue.use): fix #10573, better Vue.use type inference Apr 27, 2020
@IWANABETHATGUY
Copy link
Author

support multiple params type checking, report if Vue.use rest params doesn't match plugin install function defination

image
Vue.useparam shape doesn't match param defination
image

@IWANABETHATGUY
Copy link
Author

@posva could you please help for review my code ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant